Opened 13 years ago

Closed 12 years ago

#523 closed defect (fixed)

Fusion.SimpleSelectionObject using a global variable

Reported by: mooman Owned by: madair
Priority: P2 Milestone: Future
Component: MapGuide Version: SVN
Severity: Minor Keywords:
Cc: Browser: All
External ID: Operating System: All
state: New

Description

The initialize method in class Fusion.SimpleSelectionObject uses the variable "o" which is set via eval("o=" + r.responseText) outside the class as a global variable. It also uses the parameter that is passed in (featureInfoResponse). This is inconsistent and makes that class confusing to use. Not to mention potential bugs.

The fix is simple. Replace "o" with "featureInfoResponse".

See this line: http://trac.osgeo.org/fusion/browser/trunk/layers/MapGuide/MapGuide.js#L1432

This bug still exists in the trunk.

Thank you!

Change History (1)

comment:1 by jng, 12 years ago

Resolution: fixed
Status: newclosed

Fixed r2546

Note: See TracTickets for help on using tickets.