Opened 13 years ago

Closed 13 years ago

#463 closed defect (fixed)

Multi-map support broken in trunk

Reported by: jng Owned by: madair
Priority: P2 Milestone: Future
Component: Widgets Version: SVN
Severity: Major Keywords:
Cc: Browser: All
External ID: Operating System: All
state: New

Description

The 2.2 branch of fusion has basic support for multiple maps in a MapGroup (#428)

Unfortunately, changes in the trunk has broken this support. The legend widget now only renders the layers of the first map in the MapGroup, where previously (in the 2.2 branch) it will properly handle all the maps in the MapGroup.

Attachments (4)

multimap.PNG (130.6 KB ) - added by jng 13 years ago.
Screenshot of attempted patch (almost there)
428.mgp (21.0 KB ) - added by jng 13 years ago.
Test Package (requires Sheboygan Dataset)
463_attempt.patch (1.2 KB ) - added by jng 13 years ago.
1st attempt to fix the multi-map suport in the Legend widget
multimap_working.PNG (123.6 KB ) - added by jng 13 years ago.
Screenshot of the same appdef under our github fork for comparison

Download all attachments as: .zip

Change History (6)

by jng, 13 years ago

Attachment: multimap.PNG added

Screenshot of attempted patch (almost there)

by jng, 13 years ago

Attachment: 428.mgp added

Test Package (requires Sheboygan Dataset)

by jng, 13 years ago

Attachment: 463_attempt.patch added

1st attempt to fix the multi-map suport in the Legend widget

comment:1 by jng, 13 years ago

Ok, I noticed that the renderLegend() in LegendRendererDefault looks very similar to what was commented out here.

http://trac.osgeo.org/fusion/browser/branches/fusion-2.2/widgets/Legend.js

So I tried porting over the renderLegend() logic present in the 2.2 version and got very close (see attached multimap.png). I must be missing something. Attached is a patch of what I did to get the produced screenshot (463_attempt.patch)

Notice however that only the first map is being rendered (due to OpenLayers being updated for #464). This is better than what we had before (nothing), but something is still obviously broke.

by jng, 13 years ago

Attachment: multimap_working.PNG added

Screenshot of the same appdef under our github fork for comparison

comment:2 by jng, 13 years ago

Resolution: fixed
Status: newclosed

Multi-map support is working again

Note: See TracTickets for help on using tickets.