Opened 15 years ago
Closed 15 years ago
#330 closed defect (fixed)
Theme doesn't work on the map with commercial layers
Reported by: | liuar | Owned by: | chrisclaydon |
---|---|---|---|
Priority: | P2 | Milestone: | Future |
Component: | Widgets | Version: | 1.1.1 |
Severity: | Major | Keywords: | |
Cc: | jenny.he@… | Browser: | All |
External ID: | Operating System: | All | |
state: | Approved |
Description
Steps:
- Open one flexible web layout with commercial layers.
- Theme -> Set theme rule -> Apply
Results: Nothing changed in web layout.
Expected results: Map should display as Theme rule.
Attachments (1)
Change History (7)
comment:1 by , 15 years ago
Cc: | added |
---|
comment:2 by , 15 years ago
by , 15 years ago
Attachment: | ticket #330.patch added |
---|
comment:3 by , 15 years ago
Fix typo of my first commet section.
Apply theme invokes reloadMap in Generic.js which will reload all the commercial layers in current map. In loadMap method in Generic.js at line 77, if a commercial layer already exists, it will be destroied then create a new one . But after the layer destroyed, the pointer to the layer is not set to null which will ignore the layer’s re-creation and will cause an exception like "null reference exception" when register events to this.oLayerOL.events.
comment:6 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Submitted patch and converted the tabs it contains to spaces. In the future, please try to ensure that all tabs are converted to spaces before creating patches. Thx.
Apply theme invoke reloadMap in Generic.js which will reload all the commercial layers in current map. In loadMap method in Generic.js at line 77, if a commericial layer already exsits, it will be destroy then create a new one . But after the layer destroyed, the point to the layer is not set to null which will ignore the layer re-creation and cause a exception like "null reference exception" when register events to this.oLayerOL.events.