Opened 14 years ago
Closed 14 years ago
#313 closed defect (fixed)
PATCH: Layer checkbox is not accessed properly in show function: /www/fusion/layers/Layers.js
| Reported by: | poulet1212 | Owned by: | madair |
|---|---|---|---|
| Priority: | P2 | Milestone: | 2.2 |
| Component: | Widgets | Version: | 1.1.1 |
| Severity: | Major | Keywords: | |
| Cc: | Browser: | All | |
| External ID: | Operating System: | All | |
| state: | New |
Description
In the file: /www/fusion/layers/Layers.js (version from Mapguide 2.1 beta)
At line 322, the function:
show: function(noDraw) {
if (this.visible) {
return;
} this.oMap.showGroup(this, noDraw ? true : false); this.visible = true; if (this.legend && this.legend.checkBox) {
this.legend.checkBox.checked = true;
}
},
Should be changed like this to access correctly the legend's checkbox object of the group:
show: function(noDraw) {
if (this.visible) {
return;
} this.oMap.showGroup(this, noDraw ? true : false); this.set('visible', true); if (this.legend && this.legend.treeItem && this.legend.treeItem.checkBox) {
this.legend.treeItem.checkBox.checked = true;
}
},
The same for a layer at line: 469:
show: function(noDraw) {
if (this.visible) {
return;
} this.set('visible', true); this.oMap.showLayer(this, noDraw ? true : false); if (this.legend && this.legend.checkBox) {
this.legend.checkBox.checked = true;
}
},
should be changed like this:
show: function(noDraw) {
if (this.visible) {
return;
} this.set('visible', true); this.oMap.showLayer(this, noDraw ? true : false); if (this.legend && this.legend.treeItem && this.legend.treeItem.checkBox) {
this.legend.treeItem.checkBox.checked = true;
}
},
Change History (3)
comment:1 by , 14 years ago
| Milestone: | Future → 2.1 |
|---|
comment:2 by , 14 years ago
| Milestone: | 2.1 → 2.2 |
|---|
comment:3 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
fixed in [2202]. Thanks for the bug fix!