Legend panel is empty with Raster/WMS data source

[jennyhe]

From Autodesk QA

Stepts:

1. Create one connection to WMS.

​http://wms1.agr.gc.ca/cgi-bin/mapplant2000_f

2. New layer with any data source -> New Map->New Flexible Web layout
3. Open the web layout in IE

Results: Legend panel is empty and one error message from IE.

Expected results: Legend panel should display the layer item.

Workaround: N Regression:Y G21.6 works correctly.

[liuar]

Fixed in http://trac.osgeo.org/fusion/changeset/1934 by pdeschamps

[liuar]

The displayed raster layer icon is incorrect. I reverted the changes in http://trac.osgeo.org/fusion/changeset/1934, and it works. It seems the defect was caused by no styles in raster layer. The code logic should be updated.

Thanks, Arthur

[liuar]

Hi Paul,

Would you please review this patch for me? There's no reply from other experts, but I am not sure if my update might affect other functions.

Thanks,
Arthur

[pagameba]

I'll need to get this tested against mapserver, cc'ing Mike and Paul.

[liuar]

Hello all,

I would like to know if I could submit the code or not. Will this patch break the mapserver legend icon?

Thanks,
Arthur

[madair]

Arthur: this 3 version of the patch works slightly better for MapServer since raster layers have a valid 'style' object but no icon in it. The new patch ovrerrides the image value for raster layers. If this still works in MapGuide, I would say go ahead and commit.

[liuar]

The third patch works on MapGuide. Thanks Mike.

Arthur

[liuar]

Fixed at http://trac.osgeo.org/fusion/changeset/2060

[liuar]

Hi Mike,

Jenny and I find that the DWF icon is not the displayed incorrectly which is a disabled icon

In Legend.js, to create raster and DWF icon,

        // MapGuide Raster and DWF layer 
        if (layer.layerTypes[0] == 4 ) {
            if (style && style.staticIcon == Fusion.Constant.LAYER_DWF_TYPE) {
                opt.image = this.imgLayerDWFIcon;
            } else {
                opt.image = this.imgLayerRasterIcon;
            }
            opt.enabled = true;
        }

the DWF layer type 5 is never considered. Should be update to:

        // MapGuide Raster and DWF layer 
        if(layer.layerTypes[0] == 4){
            opt.image = this.imgLayerRasterIcon;
            opt.enabled = true;
        } else if(layer.layerTypes[0] == 5){
            opt.image = this.imgLayerDWFIcon;
            opt.enabled = true;
        }

to create the check box for layers,

              if (checkbox) {
                 layer.legend.treeItem.checkBox.checked = layer.visible?true:false;
              if (layer.layerTypes[0] == 4 || range.styles.length > 0) {
                layer.legend.treeItem.checkBox.disabled = false;
              } else {
                layer.legend.treeItem.checkBox.disabled = true;
              }
            }

which should be:

              if (checkbox) {
                 layer.legend.treeItem.checkBox.checked = layer.visible?true:false;
              if (layer.layerTypes[0] == 4 || layer.layerTypes[0] == 5 || range.styles.length > 0) {
                layer.legend.treeItem.checkBox.disabled = false;
              } else {
                layer.legend.treeItem.checkBox.disabled = true;
              }
            }

I am not sure if it's a defect or by design, so would you please give me your opinion?

Thanks,
Arthur

[madair]

The changes proposed make sense and I can verify that the Legend still works with MapServer, but it is difficult to test all the possibilities. If this fixes the issue for you and the Sheboygan legend still appears correctly I would say go ahead and make the change.

[liuar]

Changeset [2108]