Opened 15 years ago

Closed 15 years ago

#282 closed defect (fixed)

Error message in Taskpane when fusion timeout is unexpected.

Reported by: christinebao Owned by: madair
Priority: P2 Milestone: Future
Component: Widgets Version: 1.1.1
Severity: Major Keywords:
Cc: Browser: All
External ID: 1250065 Operating System: All
state: New

Description

From Autodesk QA:

Steps to reproduce:
Steps:

  1. Open one flexible web layout by IE.
  2. Wait for fusion timeout.
  3. Click Theme and Query.

Result:
The error messages on task pane are not same. They should not repeat and behave the same.

Attachments (6)

TaskPane.JPG (15.3 KB ) - added by christinebao 15 years ago.
Expected.JPG (6.4 KB ) - added by christinebao 15 years ago.
FixThemeErrorMessage.patch (687 bytes ) - added by christinebao 15 years ago.
FixQueryErrorMessage.patch (834 bytes ) - added by christinebao 15 years ago.
FixFeatureInfoErrorMessage.patch (889 bytes ) - added by christinebao 15 years ago.
Buffer.JPG (20.1 KB ) - added by christinebao 15 years ago.

Download all attachments as: .zip

Change History (18)

by christinebao, 15 years ago

Attachment: TaskPane.JPG added

comment:1 by christinebao, 15 years ago

External ID: 1250065

Attach screen shot for reference:

comment:2 by christinebao, 15 years ago

Tech diagnosis:

After investigation, the reason of this defect is that different widgets use different format to display error message. They should be fixed to be consistent.
The following patches will fix them one by one.

by christinebao, 15 years ago

Attachment: Expected.JPG added

comment:3 by christinebao, 15 years ago

The expected error message:

comment:4 by christinebao, 15 years ago

Attach patch http://trac.osgeo.org/fusion/attachment/ticket/282/FixThemeErrorMessage.patch.

This patch fixed Theme widget. If errorMsg is the same as detailMsg (detailMsg is formatted by errorMsg + '\n' + stack information, if detailMsg is not longer than errorMsg by 5 characters, treat them as same), display errorMsg is enough; otherwise display them both.

comment:5 by christinebao, 15 years ago

comment:7 by chrisclaydon, 15 years ago

In each of the patches, you're introducing a chunk of code that looks like this:


<?php } else { ?>  

<?php if ($errorDetail == null || (strlen($errorDetail) - strlen($errorMsg) < 5)) { ?>  


I think you could use "else if" instead...


<?php } else if ($errorDetail == null || (strlen($errorDetail) - strlen($errorMsg) < 5)) { ?> 

 

And the code would be a little cleaner.

by christinebao, 15 years ago

Attachment: FixThemeErrorMessage.patch added

by christinebao, 15 years ago

Attachment: FixQueryErrorMessage.patch added

by christinebao, 15 years ago

comment:9 by christinebao, 15 years ago

Submit the above patches.

comment:10 by christinebao, 15 years ago

Buffer widget is different from FeatureInfo, Query and Theme. Please see the attached image. The code is also different, and this need DM Solution to fix.

by christinebao, 15 years ago

Attachment: Buffer.JPG added

comment:11 by christinebao, 15 years ago

The screen shot for buffer widget:
Need DM Solution to fix this.

comment:12 by chrisclaydon, 15 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.