Opened 14 years ago
Closed 14 years ago
Last modified 14 years ago
#229 closed defect (fixed)
MapGuide FeatureReaders not being closed properly?
|Reported by:||jbirch||Owned by:||madair|
|External ID:||Operating System:||All|
There are a few cases where I believe an MgFeature is being opened and not being closed properly.
1) I believe that for:
There is an MgFeatureReader being opened on line 199 which is being closed on line 268.
However, on line 261, I believe that a second MgFeatureReader is being opened using the same variable name without closing the initial MgFeatureReader first, and that this second reader is never closed.
2) It looks to me that in the file
The MgFeatureReader called $features is only closed in the exception handling logic, not in the normal code stream.
On line 109, it appears that an MgFeatureReader called $featureReader is opened but not closed.
I believe that these may be the (partial?) cause of a problem I am having with running out of connections.
Change History (8)
by , 14 years ago
comment:1 by , 14 years ago
|Status:||new → closed|
thanks for the report and patches. I've applied the patch for search.php and a slightly modified version of the patch for query.php.
comment:2 by , 14 years ago
|Status:||closed → reopened|
The feature reader in SelectWithin widget still isn't closed.
comment:3 by , 14 years ago
- the feature reader opened on line 199 will not be closed if an exception is thrown from the try on line 216
- the feature reader on line 256 is not closed (I think r1874 caused a regression here)
comment:4 by , 14 years ago
ok, trying again and paying more attention to what I am doing (note this bug did not specifically mention SelectWithin but I will look at that one too).
comment:5 by , 14 years ago
|Status:||reopened → closed|
fixed in svn trunk. In query.php, the feature reader opened on line 199 will be closed after the catch statement on line 254. But the other problem is valid.
comment:6 by , 14 years ago
Read point 3 in the initial ticket :) It wasn't fixed in the patch though.
comment:7 by , 14 years ago
Opps, my bad! Fortunately I fixed the right one anyway :)
close feature readers in query.php and search.php