Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#229 closed defect (fixed)

MapGuide FeatureReaders not being closed properly?

Reported by: jbirch Owned by: madair
Priority: P2 Milestone: 2.0
Component: Widgets Version: 1.1.1
Severity: Major Keywords:
Cc: Browser: All
External ID: Operating System: All
state: New

Description

There are a few cases where I believe an MgFeature is being opened and not being closed properly.


1) I believe that for:

trunk/layers/MapGuide/php/Query.php

There is an MgFeatureReader being opened on line 199 which is being closed on line 268.

However, on line 261, I believe that a second MgFeatureReader is being opened using the same variable name without closing the initial MgFeatureReader first, and that this second reader is never closed.

2) It looks to me that in the file

trunk/widgets/Search/Search.php

The MgFeatureReader called $features is only closed in the exception handling logic, not in the normal code stream.

3) In:

trunk/widgets/SelectWithin/SelectWithin.php

On line 109, it appears that an MgFeatureReader called $featureReader is opened but not closed.


I believe that these may be the (partial?) cause of a problem I am having with running out of connections.

Attachments (1)

closeFeatureReaders.patch (1.0 KB) - added by greenmapsanmiguel 11 years ago.
close feature readers in query.php and search.php

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by greenmapsanmiguel

Attachment: closeFeatureReaders.patch added

close feature readers in query.php and search.php

comment:1 Changed 11 years ago by pagameba

Resolution: fixed
Status: newclosed

thanks for the report and patches. I've applied the patch for search.php and a slightly modified version of the patch for query.php.

comment:2 Changed 11 years ago by jbirch

Resolution: fixed
Status: closedreopened

The feature reader in SelectWithin? widget still isn't closed.

comment:3 Changed 11 years ago by jbirch

In query.php:

  • the feature reader opened on line 199 will not be closed if an exception is thrown from the try on line 216
  • the feature reader on line 256 is not closed (I think r1874 caused a regression here)

comment:4 Changed 11 years ago by pagameba

ok, trying again and paying more attention to what I am doing (note this bug did not specifically mention SelectWithin? but I will look at that one too).

comment:5 Changed 11 years ago by pagameba

Resolution: fixed
Status: reopenedclosed

fixed in svn trunk. In query.php, the feature reader opened on line 199 will be closed after the catch statement on line 254. But the other problem is valid.

comment:6 Changed 11 years ago by jbirch

Read point 3 in the initial ticket :) It wasn't fixed in the patch though.

comment:7 Changed 11 years ago by pagameba

Opps, my bad! Fortunately I fixed the right one anyway :)

Note: See TracTickets for help on using tickets.