Opened 2 years ago

Closed 10 months ago

Last modified 9 months ago

#949 closed task (fixed)

Check if joining to pg_authid is necessary for listing materialized views

Reported by: jng Owned by: jng
Priority: major Milestone: 4.1.0
Component: PostgreSQL Provider Version: 4.1.0
Severity: 3 Keywords:
Cc: External ID:

Description

#943 added support for materialized views. However the SQL to query for these materialized views includes a join to the pg_authid table/view which seems unnecessary as the joined table is not part of any output columns or where clauses.

For the purpose of attack surface reduction, we should check if this join is even necessary and remove it if such a join is not necessary.

Change History (3)

comment:1 Changed 10 months ago by jng

Resolution: fixed
Status: assignedclosed

In 7953:

Remove join to pg_authid in table/view listing query. It does not appear to be necessary and our materialized view test still passes.

Fixes #949

comment:2 Changed 9 months ago by jng

In 7954:

Remove join to pg_authid in table/view listing query. It does not appear to be necessary and our materialized view test still passes.

Fixes #949

comment:3 Changed 9 months ago by jng

In 7955:

Merged revision(s) 7952-7954 from trunk:
Merged revision(s) 7951 from branches/4.1:
#893: Refine the vndr_info reporting for MySQL driver to report the correct version number for MariaDB, allowing the full spatial capability suite to light up for the MySQL provider when connecting to MariaDB
........

........
Remove join to pg_authid in table/view listing query. It does not appear to be necessary and our materialized view test still passes.

Fixes #949
........

Note: See TracTickets for help on using tickets.