Opened 6 years ago

Closed 2 years ago

#883 closed defect (fixed)

Unit Test Suite instability

Reported by: jng Owned by: jng
Priority: major Milestone:
Component: FDO API Version:
Severity: 3 Keywords:
Cc: External ID:

Description

I recently ran most of the FDO unit test suite and the results were somewhat unsettling:

The results so far can be found in this spreadsheet (with CppUnit? failures included):

https://docs.google.com/spreadsheet/ccc?key=0AhBgYUE6W7xydEhmQjBIUHpUSzNGMFpLYWE4YmRSWnc&usp=drive_web#gid=0

Some of the identified causes for these failures thus far are due to:

  • SHP: Unit tests referencing test data that was removed in #230
  • GenericRdbms?: Tests referencing the Autodesk.Oracle FDO provider
  • GenericRdbms?: Small changes to the expected output and the master txt files have not been updated
  • GenericRdbms?: An improperly initialized wchar_t array in UnitTestUtil::Sql2Db() causing buffer overrun errors in SQL Server, MySQL and PostGis? test runners in x64 release mode.
  • GenericRdbms?: ExtendedCoordSys.txt not copied to the $OUTDIR/com directory
  • GenericRdbms?: postgis_fdo_sys.sql and postgis_fdo_sys_idx.sql not copied to the $OUTDIR/com directory
  • SDF: Segfaulting test runner on Ubuntu due to missing realpath() fixes not ported over from the linux64 sandbox.

Attachments (3)

UnitTest_GenericRdbms.patch (47.4 KB) - added by jng 6 years ago.
Unit test fixes for GenericRdbms?
UnitTest_SHP.patch (6.0 KB) - added by jng 6 years ago.
#ifdef out SHP tests using data not in OS branch of FDO
UnitTest_SDF.patch (15.9 KB) - added by jng 6 years ago.
Fixes for SDF Provider

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by jng

Attachment: UnitTest_GenericRdbms.patch added

Unit test fixes for GenericRdbms?

Changed 6 years ago by jng

Attachment: UnitTest_SHP.patch added

#ifdef out SHP tests using data not in OS branch of FDO

comment:1 Changed 6 years ago by jng

UnitTest_GenericRdbms.patch fixes the following:

  • ExtendedCoordSys.txt not being copied to $OUTDIR/com in release configuration of UnitTestSQLServerSpatial. Some unit tests failed because this file was not there.
  • postgis_fdo_sys.sql and postgis_fdo_sys_idx.sql not being copied to $OUTDIR/com in release configuration of UnitTestPostGis?. A lot of unit tests failed because these files were not there.
  • Fix improperly initialized lineBuffer in UnitTestUtil::Sql2Db() which caused buffer overrun errors in the SQL Server, MySQL and PostGis? test runners in x64 release mode
  • #ifdef out tests involving Autodesk.Oracle override XML documents. These tests are enabled by defining ADSK_FDO
  • Fix formatting on some of the master text files to ensure before/after output comparison is correct

UnitTest_SHP.patch #ifdefs out tests involving test data that was removed as a result of #230. These tests are enabled by defining ADSK_FDO

Changed 6 years ago by jng

Attachment: UnitTest_SDF.patch added

Fixes for SDF Provider

comment:2 Changed 6 years ago by jng

UnitTest_SDF.patch fixes the following:

  • Segfaults on Ubuntu due to buffer overflow on realpath(). Fixes were in the linux64 sandbox, but were never brought over to trunk.
  • FdoMessage?.dll was not copied to the output directory in release mode, causing several unit test failures asserting on expected error messages
  • Some master text files have incorrect formatting

comment:3 Changed 2 years ago by jng

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.