Opened 13 years ago

Closed 13 years ago

#829 closed defect (fixed)

"Internal error" is meaningless in most contexts where it is thrown

Reported by: jng Owned by: gregboone
Priority: major Milestone:
Component: ODBC Provider Version: 3.6.0
Severity: 3 Keywords:
Cc: External ID:

Description

I've been trying to query a ODBC-configured Feature Class (X/Y columns mapped to point geometries) in the latest MGOS 2.4 beta (using FDO 3.7), querying the feature class will cause the provider to throw "internal error".

Doing the same query with FDO Toolbox 1.0 (using FDO 3.6) throws the same error.

I've looked at GenericRdbms source (mostly FdoRdbmsFilterProcessor.cpp) finding the cases where the "internal error" exception is thrown and over half of them are due to a FDO logical property being mapped to a non-existent physical column.

In such cases, throwing an exception with the message "Could not find the mapped physical column for property %s" is a much more helpful one as I already know that something in my ODBC configuration document is causing this error.

Such a message like the one proposed gives me greater context for debugging the problem.

Attachments (1)

internal_error_replacement.patch (5.3 KB ) - added by jng 13 years ago.

Download all attachments as: .zip

Change History (2)

comment:1 by jng, 13 years ago

Resolution: fixed
Status: newclosed

Fixed in trunk r6459 and 3.7 r6460

Note: See TracTickets for help on using tickets.