Opened 8 years ago

Closed 8 years ago

#807 closed defect (fixed)

SHP Provider: Multi-polygon geometry type is not exposed via GetGeometryComponentTypes()

Reported by: danstoica Owned by: gregboone
Priority: major Milestone: 3.7.0
Component: FDO API Version: 3.7.0
Severity: 3 Keywords:
Cc: External ID:


This is a legacy defect in ShpLpClassDefinition::ConvertPhysicalToLogicalGeometryProperty?(), line #753:

case ePolygonShape:

geomTypesDest[0] = FdoGeometryType_Polygon; geomTypeCount=1;

It should read instead:

case ePolygonShape:

geomTypesDest[0] = FdoGeometryType_Polygon; geomTypesDest[1] = FdoGeometryType_MultiPolygon; geomTypeCount=2;

(the same for other types of polygons)

The rationale is that in fact SHP provider allows both Polygon and multi-Polygon features in the same file. Thus ShpGeometryCapabilities::GetGeometryComponentTypes?() should return both Polygon and Multipolygon types, similar to the LineString?.

Change History (1)

comment:1 Changed 8 years ago by danstoica

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.