Opened 14 years ago

Closed 13 years ago

#171 closed defect (fixed)

Fdo Postgis Autogenated identity property is mandatory

Reported by: bscott Owned by: mloskot
Priority: major Milestone: 3.4.0
Component: PostGIS Provider Version: 3.2.0
Severity: 3 Keywords:
Cc: External ID:

Description (last modified by jbirch)

With FDO it is possible to create a column with Primary = true and autogenerate = false. I think the PostGis provider should not do that assumption and let the user manage the primary key if the autogenerate flag is set to false.

Actually it is mandatory there is the piece of code where you can find the limitation:


void SchemaDescription::DescribeSchema(Connection* conn, FdoString* schemaName) 
{ 
  ... 
        ////////////////// SET AUTO-GENERATED TO SINGLE COLUMN PK OF 
 INTEGRAL TYPE ////////////////// 
  
// TODO: It is possible, that user connects to a datastore that was not created 
// with FDO, using ApplySchema command, so single column PRIMARY  KEY 
// of integral type, may not have associated sequence named according scheme: 
// <tablename>_<columnname>_seq 
// The PostGIS provider uses such scheme to bind a sequence to PK column. 
   
// TODO: In future, it would be a good idea to automatically 
// replace PK of integral type with serial data type, in ApplySchema command. 
     FdoPtr<FdoDataPropertyDefinitionCollection> propsIdentity;   
     propsIdentity = featClass->GetIdentityProperties();  
     if (1 == propsIdentity->GetCount()) 
     { 
       FdoPtr<FdoDataPropertyDefinition> propId = propsIdentity->GetItem(0);  
       assert(NULL != propId); 
   
       if (FdoDataType_Int16 == propId->GetDataType()   
        || FdoDataType_Int32 == propId->GetDataType() 
        || FdoDataType_Int64 == propId->GetDataType()) 
       { 
         propId->SetIsAutoGenerated(true); 
       } 
     } 


Change History (5)

comment:1 Changed 13 years ago by gregboone

Milestone: 3.3.03.3.1

comment:2 Changed 13 years ago by mloskot

Patch submitted for review as #318

comment:3 Changed 13 years ago by jbirch

Description: modified (diff)

Just fixing up the ticket description...

comment:4 Changed 13 years ago by mloskot

Status: newassigned

comment:5 Changed 13 years ago by mloskot

Resolution: fixed
Status: assignedclosed

Fixed in trunk (r3904) with patch from Bruno Scott. I'm closing it as fixed. Please, reopen if something is still not working well.

Note: See TracTickets for help on using tickets.