Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#930 closed bug (fixed)

SPIT does allow to connect to PostGIS

Reported by: msieczka Owned by: nobody
Priority: major: does not work as expected Milestone:
Component: SPIT Version: Trunk
Keywords: pgsql postgis import Cc:
Must Fix for Release: Yes Platform: Debian
Platform Version: ubuntu 7.10 amd64 Awaiting user input: no

Description

In SPIT I have setup the connection. The "Test Connect" says: "Connection to <database name here> was successfull". However, the "Connect" button in SPIT is greyed-out, inactive.

The same connection setup that SPIT refuses to use works OK for "Add a PostGIS Layer" dialog.

If in SPIT I choose a shapefile and press OK anyway, even though it seems I'm not connected (the "Connect" button is greyed-out all the time) and press OK, SPIT segfaults like described in the bug #865 (reported 2 months ago).

Attachments (1)

patch_for_bug_930.txt (27.7 KB ) - added by jef 16 years ago.
patch to apply after string freeze

Download all attachments as: .zip

Change History (12)

in reply to:  description comment:1 by azog, 16 years ago

Keywords: pgsql postgis import added
Platform Version: ubuntu 7.10 amd64

Replying to msieczka:

In SPIT I have setup the connection. The "Test Connect" says: "Connection to <database name here> was successfull". However, the "Connect" button in SPIT is greyed-out, inactive.

The same connection setup that SPIT refuses to use works OK for "Add a PostGIS Layer" dialog.

If in SPIT I choose a shapefile and press OK anyway, even though it seems I'm not connected (the "Connect" button is greyed-out all the time) and press OK, SPIT segfaults like described in the bug #865 (reported 2 months ago).

I have the exact same experience on ubuntu 7.10 amd64, running 0.9.2 w/pgsql 8.2.6+postgis. I can connect to the database, no problem w/test connection, but not in SPIT. When trying to go ahead anyway, I also experience a crash.

comment:2 by jef, 16 years ago

Resolution: fixed
Status: newclosed
Summary: SPIT does allow to connect to PostGIS8

fixed in r8293

comment:3 by jef, 16 years ago

Summary: 8SPIT does allow to connect to PostGIS

comment:4 by msieczka, 16 years ago

Author: jef

  • remove disabled connect button (spit automatically connects on OK)

First of all it's great you found time to fix SPIT. Very much appreciated!

Regarding the connect button removal however I have doubts:

  1. Actually now SPIT automatically connects right away on it's startup, not on OK later. This forces and arbitrary connection to be chosen by default, if you have more available.
  1. A missing connect button makes SPIT interface different from add PostGIS layer dialog for no reason; each such difference makes it harder for newcomers and QGIS teachers (they ask me "But why do the two differ?", I say "Just because.". Neither me nor they are satisfied with the reply :) ).

BTW - SPIT fails to ask for password if the given connection does not have one saved. It just yields an error "Connection failed - Check settings and try again". Same as "Test connection" button. Could they instead pop up a dialog for password, like the Add PostGIS Layer dialog does after pressing the connect button?

by jef, 16 years ago

Attachment: patch_for_bug_930.txt added

patch to apply after string freeze

comment:5 by jef, 16 years ago

the patch patch fixes the connection problem. As we are currently in string freeze this will not make it into 0.9.2.

comment:6 by msieczka, 16 years ago

Resolution: fixed
Status: closedreopened

Thanks Jürgen

I'll reopen the ticket so it's not missed when the patch can be applied.

comment:7 by jef, 16 years ago

Resolution: fixed
Status: reopenedclosed

fixed in trunk r8367

comment:8 by msieczka, 16 years ago

Yuppie!

comment:9 by msieczka, 16 years ago

I mean: Yippie! (ki-yay). :D

comment:10 by msieczka, 16 years ago

Darn, I mean "Yippee!" (and promise this is my last spam here).

comment:11 by (none), 15 years ago

Milestone: Version 0.9.2

Milestone Version 0.9.2 deleted

Note: See TracTickets for help on using tickets.