Ticket #930 (closed bug: fixed)

Opened 5 years ago

Last modified 4 years ago

SPIT does allow to connect to PostGIS

Reported by: msieczka Owned by: nobody
Priority: major: does not work as expected Milestone:
Component: SPIT Version: Trunk
Keywords: pgsql postgis import Cc:
Platform Version: ubuntu 7.10 amd64 Platform: Debian
Must Fix for Release: Yes Awaiting user input: no

Description

In SPIT I have setup the connection. The "Test Connect" says: "Connection to <database name here> was successfull". However, the "Connect" button in SPIT is greyed-out, inactive.

The same connection setup that SPIT refuses to use works OK for "Add a PostGIS Layer" dialog.

If in SPIT I choose a shapefile and press OK anyway, even though it seems I'm not connected (the "Connect" button is greyed-out all the time) and press OK, SPIT segfaults like described in the bug #865 (reported 2 months ago).

Attachments

patch_for_bug_930.txt Download (27.7 KB) - added by jef 5 years ago.
patch to apply after string freeze

Change History

in reply to: ↑ description   Changed 5 years ago by azog

  • keywords pgsql postgis import added
  • platform_version set to ubuntu 7.10 amd64

Replying to msieczka:

In SPIT I have setup the connection. The "Test Connect" says: "Connection to <database name here> was successfull". However, the "Connect" button in SPIT is greyed-out, inactive. The same connection setup that SPIT refuses to use works OK for "Add a PostGIS Layer" dialog. If in SPIT I choose a shapefile and press OK anyway, even though it seems I'm not connected (the "Connect" button is greyed-out all the time) and press OK, SPIT segfaults like described in the bug #865 (reported 2 months ago).

I have the exact same experience on ubuntu 7.10 amd64, running 0.9.2 w/pgsql 8.2.6+postgis. I can connect to the database, no problem w/test connection, but not in SPIT. When trying to go ahead anyway, I also experience a crash.

  Changed 5 years ago by jef

  • status changed from new to closed
  • resolution set to fixed
  • summary changed from SPIT does allow to connect to PostGIS to 8

fixed in r8293

  Changed 5 years ago by jef

  • summary changed from 8 to SPIT does allow to connect to PostGIS

  Changed 5 years ago by msieczka

Author: jef

- remove disabled connect button (spit automatically connects on OK)

First of all it's great you found time to fix SPIT. Very much appreciated!

Regarding the connect button removal however I have doubts:

1. Actually now SPIT automatically connects right away on it's startup, not on OK later. This forces and arbitrary connection to be chosen by default, if you have more available.

2. A missing connect button makes SPIT interface different from add PostGIS layer dialog for no reason; each such difference makes it harder for newcomers and QGIS teachers (they ask me "But why do the two differ?", I say "Just because.". Neither me nor they are satisfied with the reply :) ).

BTW - SPIT fails to ask for password if the given connection does not have one saved. It just yields an error "Connection failed - Check settings and try again". Same as "Test connection" button. Could they instead pop up a dialog for password, like the Add PostGIS Layer dialog does after pressing the connect button?

Changed 5 years ago by jef

patch to apply after string freeze

  Changed 5 years ago by jef

the patch patch fixes the connection problem. As we are currently in string freeze this will not make it into 0.9.2.

  Changed 5 years ago by msieczka

  • status changed from closed to reopened
  • resolution fixed deleted

Thanks Jürgen

I'll reopen the ticket so it's not missed when the patch can be applied.

  Changed 5 years ago by jef

  • status changed from reopened to closed
  • resolution set to fixed

fixed in trunk r8367

  Changed 5 years ago by msieczka

Yuppie!

  Changed 5 years ago by msieczka

I mean: Yippie! (ki-yay). :D

  Changed 5 years ago by msieczka

Darn, I mean "Yippee!" (and promise this is my last spam here).

  Changed 4 years ago by anonymous

  • milestone Version 0.9.2 deleted

Milestone Version 0.9.2 deleted

Note: See TracTickets for help on using tickets.