qgis trunk crashes when saving project or clicking "OK" in the "new shape" dialog (or when using other dialogs)

[lutra]

Confirmed under Ubuntu and Windows.

Program seg faults. The responsible seems to be part of the code of the new "customization" feature

 QgsCustomization::preNotify (this=0x861c720, receiver=0x98c9d70, event=0x98e6420, done=0xb16d4f7f)
at /home/brushtyler/projects/sources/qgis/src/app/qgscustomization.cpp:841

[lutra]

More crashes for example when clicking "ok" or selecting files in various raster menu tools.

Debug: /home/brushtyler/projects/sources/qgis/src/app/qgscustomization.cpp: 794: (customizeWidget) p = /Customization/Widgets//QFileDialog/ on = 1
Debug: /home/brushtyler/projects/sources/qgis/src/app/qgscustomization.cpp: 860: (preNotify) click
Fatal: ASSERT: "d" in file /usr/include/qt4/QtCore/qscopedpointer.h, line 112

[brushtyler]

It occurs closing non-native file dialogs (look at the difference between Save project and SaveAs? project dialogs), either by pressing ok or cancel buttons.

Adding a check to exclude QFileDialog instances (as done for not QDialog instances) doesn't work as expected. In fact the problem is at line 841 trying to cast QObject to QWidget because the object was deleted yet before the preNotify was called.

I've attached a backtrace.

[brushtyler]

backtrace

[alexbruy]

Confirmed under Slackware with latest self-compiled sources (c3e161a).

[alexbruy]

Seems Windows builds not affected (tested with ef981f1)

[rblazek]

It should be fixed in 4070354d5.

Please test and close if it works.

[alexbruy]

Fixed in commit:4070354d5f0a8f401d3c