Random points ftools issue

[dr]

1. Open shapefile:  http://gis-lab.info/data/vmap0/bounds-correct.7z;
2. Try to put two random points with Random points tool;
At result I get an error:

An error has occured while executing Python code:

Traceback (most recent call last):
  File "C:\OSGeo4W\apps\qgis-dev\python\plugins\fTools\tools\doRandPoints.py", line 123, in accept
    self.randomize(inLayer, outPath, minimum, design, value, self.progressBar)
  File "C:\OSGeo4W\apps\qgis-dev\python\plugins\fTools\tools\doRandPoints.py", line 209, in randomize
    else: bound = self.createSinglePolygon(inLayer, progressBar)
  File "C:\OSGeo4W\apps\qgis-dev\python\plugins\fTools\tools\doRandPoints.py", line 155, in createSinglePolygon
    geom = geom.combine(QgsGeometry( feat.geometry() ))
AttributeError: 'NoneType' object has no attribute 'combine'

Python version:
2.5.2 (r252:60911, Feb 21 2008, 13:11:45) [MSC v.1310 32 bit (Intel)]

[lutra]

I tested both under windows (xp) and linux and got no python errors, but the tool is way too slow: I waited something like 10 minutes just to see the progress bar arrive at 41% and then become apparently stuck.

[gislab]

I confirm, mine stuck at 14% with 10 random points. No error though.

[pcav]

Got a different error:

Traceback (most recent call last): File "/usr/share/qgis/python/plugins/fTools/tools/doRandPoints.py", line 124, in accept self.randomize(inLayer, outPath, minimum, design, value) File "/usr/share/qgis/python/plugins/fTools/tools/doRandPoints.py", line 186, in randomize else: points = self.loopThruPolygons(inLayer, value, design) File "/usr/share/qgis/python/plugins/fTools/tools/doRandPoints.py", line 227, in loopThruPolygons value = sAtMap[index].toInt()[0] UnboundLocalError?: local variable 'index' referenced before assignment

Versione Python: 2.6.5 (r265:79063, Mar 18 2010, 23:59:47) [GCC 4.4.3]

Strangely enough, this does not happen with some PC, for unknown reasons.

[pcav]

See also #2495 (partial duplicate).

[brushtyler]

Replying to pcav:

Got a different error: Traceback (most recent call last): File "/usr/share/qgis/python/plugins/fTools/tools/doRandPoints.py", line 124, in accept self.randomize(inLayer, outPath, minimum, design, value) File "/usr/share/qgis/python/plugins/fTools/tools/doRandPoints.py", line 186, in randomize else: points = self.loopThruPolygons(inLayer, value, design) File "/usr/share/qgis/python/plugins/fTools/tools/doRandPoints.py", line 227, in loopThruPolygons value = sAtMap[index].toInt()[0] UnboundLocalError?: local variable 'index' referenced before assignment Versione Python: 2.6.5 (r265:79063, Mar 18 2010, 23:59:47) [GCC 4.4.3] Strangely enough, this does not happen with some PC, for unknown reasons.

I've found the issue: the reason is the used language. I'm writing a patch.

[brushtyler]

patch to fix the error reported in the 3rd comment

[cfarmer]

fixed in r13860 and r13861

Carson