Ticket #1516 (closed patch: fixed)

Opened 4 years ago

Last modified 4 years ago

qgis 1.0.0 does not build with CXXFLAGS="-Werror=format-security"

Reported by: fundawang Owned by: jef
Priority: minor: annoyance Milestone:
Component: Build/Install Version: 1.0.0
Keywords: Cc:
Platform Version: Platform: Mandriva
Must Fix for Release: Yes Awaiting user input: no

Description

-Werror=format-security is used to detect format string of functions like printf(), QDebug(), to ensure that the format string is plain string rather than unknown variable. So Mandriva enables it by default in 2009.1.

There are some insecure format strings in qgis, which will report errors when using such a compiler flag.

Please consider merging this patch:  http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/qgis/current/SOURCES/qgis_1.0.0-fix-str-fmt.patch

Change History

Changed 4 years ago by pcav

  • owner changed from nobody to jef

Changed 4 years ago by jef

  • status changed from new to closed
  • resolution set to fixed

added -Wformat-security to PEDANTIC build settings in r10078 and fixed the resulting warnings in r10084

Changed 4 years ago by anonymous

  • milestone Version 1.0.1 deleted

Milestone Version 1.0.1 deleted

Note: See TracTickets for help on using tickets.