Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#1516 closed patch (fixed)

qgis 1.0.0 does not build with CXXFLAGS="-Werror=format-security"

Reported by: fundawang Owned by: jef
Priority: minor: annoyance Milestone:
Component: Build/Install Version: 1.0.0
Keywords: Cc:
Must Fix for Release: Yes Platform: Mandriva
Platform Version: Awaiting user input: no

Description

-Werror=format-security is used to detect format string of functions like printf(), QDebug(), to ensure that the format string is plain string rather than unknown variable. So Mandriva enables it by default in 2009.1.

There are some insecure format strings in qgis, which will report errors when using such a compiler flag.

Please consider merging this patch: http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/qgis/current/SOURCES/qgis_1.0.0-fix-str-fmt.patch

Change History (3)

comment:1 by pcav, 15 years ago

Owner: changed from nobody to jef

comment:2 by jef, 15 years ago

Resolution: fixed
Status: newclosed

added -Wformat-security to PEDANTIC build settings in r10078 and fixed the resulting warnings in r10084

comment:3 by (none), 15 years ago

Milestone: Version 1.0.1

Milestone Version 1.0.1 deleted

Note: See TracTickets for help on using tickets.