Ticket #1446 (closed patch: fixed)

Opened 4 years ago

Last modified 4 years ago

implement add/del field for Shapefiles

Reported by: msieczka Owned by: jef
Priority: major: does not work as expected Milestone:
Component: OGR Layer support Version: Trunk
Keywords: Cc:
Platform Version: Platform: All
Must Fix for Release: No Awaiting user input: no

Description

Now that creation of new fields in an existing DBF table via OGR is possible [1] please implement this functionality in table editor fro Shapefiles.

[1] http://trac.osgeo.org/gdal/ticket/2672

Attachments

patch_for_1446.diff Download (2.9 KB) - added by jef 4 years ago.
patch that enables adding of attributes in shapefiles via OGR

Change History

Changed 4 years ago by jef

patch that enables adding of attributes in shapefiles via OGR

follow-up: ↓ 2   Changed 4 years ago by jef

  • type changed from enhancement to patch

OGR still doesn't support deletion of fields.

in reply to: ↑ 1   Changed 4 years ago by wonder

Replying to jef:

OGR still doesn't support deletion of fields.

Indeed it doesn't, however there's a patch pending:

 http://trac.osgeo.org/gdal/ticket/2671

Martin

  Changed 4 years ago by jef

  • owner changed from nobody to jef

  Changed 4 years ago by mhugent

One issue I had with this patch: after commiting the added fields, they where not visible in the attribute table and with the info tools. I had to remove and reopen the layer to have the fields in the attribute table. Would it be possible to reopen the OGR datasource inside the ogr provider after adding fields?

Thanks, Marco

  Changed 4 years ago by mhugent

  • milestone changed from Version 1.0.0 to Version 1.0.1

I'm suggesting to push this to 1.0.1 to have more time for testing

follow-up: ↓ 7   Changed 4 years ago by pcav

Would this be the right time to apply it to trunk?

in reply to: ↑ 6   Changed 4 years ago by jef

  • status changed from new to closed
  • resolution set to fixed

Replying to pcav:

Would this be the right time to apply it to trunk?

applied in r9982

  Changed 4 years ago by anonymous

  • milestone Version 1.0.1 deleted

Milestone Version 1.0.1 deleted

Note: See TracTickets for help on using tickets.