Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#1446 closed patch (fixed)

implement add/del field for Shapefiles

Reported by: msieczka Owned by: jef
Priority: major: does not work as expected Milestone:
Component: OGR Layer support Version: Trunk
Keywords: Cc:
Must Fix for Release: No Platform: All
Platform Version: Awaiting user input: no

Description

Now that creation of new fields in an existing DBF table via OGR is possible [1] please implement this functionality in table editor fro Shapefiles.

[1]http://trac.osgeo.org/gdal/ticket/2672

Attachments (1)

patch_for_1446.diff (2.9 KB ) - added by jef 15 years ago.
patch that enables adding of attributes in shapefiles via OGR

Download all attachments as: .zip

Change History (9)

by jef, 15 years ago

Attachment: patch_for_1446.diff added

patch that enables adding of attributes in shapefiles via OGR

comment:1 by jef, 15 years ago

Type: enhancementpatch

OGR still doesn't support deletion of fields.

in reply to:  1 comment:2 by wonder, 15 years ago

Replying to jef:

OGR still doesn't support deletion of fields.

Indeed it doesn't, however there's a patch pending:

http://trac.osgeo.org/gdal/ticket/2671

Martin

comment:3 by jef, 15 years ago

Owner: changed from nobody to jef

comment:4 by mhugent, 15 years ago

One issue I had with this patch: after commiting the added fields, they where not visible in the attribute table and with the info tools. I had to remove and reopen the layer to have the fields in the attribute table. Would it be possible to reopen the OGR datasource inside the ogr provider after adding fields?

Thanks, Marco

comment:5 by mhugent, 15 years ago

Milestone: Version 1.0.0Version 1.0.1

I'm suggesting to push this to 1.0.1 to have more time for testing

comment:6 by pcav, 15 years ago

Would this be the right time to apply it to trunk?

in reply to:  6 comment:7 by jef, 15 years ago

Resolution: fixed
Status: newclosed

Replying to pcav:

Would this be the right time to apply it to trunk?

applied in r9982

comment:8 by (none), 15 years ago

Milestone: Version 1.0.1

Milestone Version 1.0.1 deleted

Note: See TracTickets for help on using tickets.