Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#1443 closed bug (fixed)

Changed layer saving enhancement

Reported by: borysiasty Owned by: mhugent
Priority: critical: causes crash or data corruption Milestone: Version 1.2.0
Component: Digitising Version: Trunk
Keywords: vector layer edit save changes Cc:
Must Fix for Release: Yes Platform: All
Platform Version: Awaiting user input: no

Description

When closing QGis containing a vector layer in edit mode, no warning is displayed and changes are being lost. The same when the layer is being removed from the legend.

I propose to implement one consistent behaviour: If user is closing a layer which contains any unsaved changes (because is either in editing mode or changed by a plugin or the Python Console), a warning message is displayed with three options:

  • drop changes
  • save layer (if supported)
  • save as shapefile

Change History (7)

comment:1 by msieczka, 15 years ago

Component: VectorsDigitising
Must Fix for Release: NoYes
Priority: minor: annoyance or enhancementcritical: causes crash or data corruption
Type: enhancementbug

comment:2 by pcav, 15 years ago

Summary: Changed layer saving enchancementChanged layer saving enhancement

comment:3 by lutra, 15 years ago

Milestone: Version 1.0.3Version 1.2.0

comment:4 by pcav, 15 years ago

Owner: changed from nobody to mhugent

comment:5 by mhugent, 15 years ago

Resolution: fixed
Status: newclosed

Fixed in r11290

comment:6 by lutra, 15 years ago

great news, thanks.

I noticed that if it is the case, qgis notices about saving the project before asking to save the changes to a layer. Maybe it is worth to exchange the priority of the two.

Ciao

comment:7 by mhugent, 15 years ago

I thought of that too. However, the user still has the possibility to cancel if asked to save the changes. If he cancels, I assume he hit the button by mistake and also want the layers to stay editable. In this case it is better to ask to save edit changes afterwards.

Note: See TracTickets for help on using tickets.