Ticket #14 (closed bug: fixed)

Opened 7 years ago

Last modified 4 years ago

QgsGeometryVertexIndex::operator= must return a value

Reported by: mloskot Owned by: gsherman
Priority: major: does not work as expected Milestone:
Component: Vectors Version: Trunk
Keywords: Cc:
Platform Version: Platform: All
Must Fix for Release: No Awaiting user input: no

Description

Small bug in file qgsgeometryvertexindex.cpp (revision 4502), lines 31-34: QgsGeometryVertexIndex::operator= must return a value.

Current incomplete version:

QgsGeometryVertexIndex&
QgsGeometryVertexIndex::operator=(QgsGeometryVertexIndex const& rhs)
{
   mIndex = rhs.mIndex;
}

Possible min. required fix:

QgsGeometryVertexIndex&
QgsGeometryVertexIndex::operator=(QgsGeometryVertexIndex const& rhs)
{
   mIndex = rhs.mIndex;
   return *this
}

But I'm not sure what copy semantic is expected here. What about self-copying? Usually, self-copying is forbidden, then

QgsGeometryVertexIndex&
QgsGeometryVertexIndex::operator=(QgsGeometryVertexIndex
const& rhs)
{
   if (&rhs != this)
   {
      mIndex = rhs.mIndex;
   }
   return *this
}

Change History

Changed 7 years ago by gsherman

  • status changed from new to closed
  • resolution set to fixed

Changed 6 years ago by anonymous

  • status_info unset
  • must_fix set to No

Changed 4 years ago by anonymous

  • milestone Version 0.8 deleted

Milestone Version 0.8 deleted

Note: See TracTickets for help on using tickets.