Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#1101 closed patch (fixed)

GRASS Toolbox Enhancements

Reported by: marcopx Owned by: timlinux
Priority: major: does not work as expected Milestone:
Component: GRASS Version: Trunk
Keywords: grass toolbox Cc: marco.pasetti@…
Must Fix for Release: Yes Platform: All
Platform Version: All Awaiting user input: no

Description

Hi all,

Even if I named the short summary as "Enhancement", some changes to the qgm GRASS modules I'm proposing here are in fact major priorities, since many modules don't work as expected/needed.

A brief summary of the previous job, already posted to the list:

New/modified/renamed modules introduced in the previous job:

  • g.region.save
  • g.region.zoom
  • g.region.multiple.raster
  • g.region.multiple.vector
  • r.patch
  • v.patch
  • r.proj
  • r.proj.res
  • v.in.db
  • v.in.ogr
  • v.in.ogr.loc
  • v.in.ogr.all
  • v.in.ogr.all.loc
  • v.in.shape
  • v.in.shape.loc

for more details on the changes listed above, see: http://lists.osgeo.org/pipermail/qgis-developer/2008-May/003797.html

News in the current job:

I modified descriptions of some g.proj modules (IMHO not correctly reflecting the real job of the modules) and added the g.proj.ascii module for coherency:

Module - New description

  • g.proj.print - Print projection information of the current location
  • g.proj.geo - Print projection information from a georeferenced file (raster, vector or image)
  • g.proj.ascii - Print projection information from a georeferenced ASCII file containing a WKT projection description
  • g.proj.proj - Print projection information from a PROJ.4 projection description file

  • g.proj.geo.new - Print projection information from a georeferenced file (raster, vector or image) and create a new location based on it
  • g.proj.ascii.new - Print projection information from a georeferenced ASCII file containing a WKT projection description and create a new location based on it
  • g.proj.proj.new - Print projection information from a PROJ.4 projection description file and create a new location based on it

Then I found that the g.proj.region is not included in the default.qgc configuration file, and that it is actually an useless module

As usual, all the changes have been tested on the svn 0.10.0 release code.

Summarizing, I suggest to test as follows:

  1. remove g.proj.region (.qgm + .1.png) [not included in ./config/default.qgc and actually useless]
  1. remove g.region (.qgm + .1.png) [replaced by g.proj.save]
  1. remove g.proj.print.2.png [according to the new ./config/default.qgc layout, where I *normalized* the tree]
  1. add the new modules (extract the zip to ../src/plugins/grass/modules and modify the ./config/default.qgc patching the svn qgis-trunk diff attached]

run cmakesetup .. to apply the changes in default.qgc, then build

Best regards,

Marco

Change History (7)

comment:1 by marcopx, 16 years ago

Since the files are too big to be attached, I uploaded them to my personal web area:

http://www.webalice.it/marco.pasetti/qgis/grass-toolbox-new-files.zip

http://www.webalice.it/marco.pasetti/qgis/default.qgc.svn.diff

Marco

comment:2 by timlinux, 16 years ago

Owner: changed from nobody to timlinux
Type: enhancementpatch

Hi Marco

What is the status of these changes? Do they need to be applied still and are the patches still valid? Leonardo could you evaluate these changes?

in reply to:  2 comment:3 by marcopx, 16 years ago

Replying to timlinux:

Hi Marco

What is the status of these changes? Do they need to be applied still and are the patches still valid? Leonardo could you evaluate these changes?

Hi Tim,

I need to check out that, I still not finished to build all. I'll let you know.

Marco

in reply to:  2 comment:4 by marcopx, 16 years ago

Replying to timlinux:

Hi Marco

What is the status of these changes? Do they need to be applied still and are the patches still valid? Leonardo could you evaluate these changes?

It seems that the changes have been not backported to 0.11.0 as they should have been. I need to retrieve the discussion with Leo of some weeks (months?) ago about what to keep or not.

Leo, could you help me with that?

Marco

in reply to:  2 comment:5 by marcopx, 16 years ago

Replying to timlinux:

Hi Marco

What is the status of these changes? Do they need to be applied still and are the patches still valid? Leonardo could you evaluate these changes?

Tim,

OK. Now I got the point. The changes still need to be applied, and they are very important... but I need svn access to do that. Maybe jef or you could do the job for me?

Marco

comment:6 by jef, 16 years ago

Resolution: fixed
Status: newclosed

fixed r8798

comment:7 by (none), 15 years ago

Milestone: Version 1.0.0

Milestone Version 1.0.0 deleted

Note: See TracTickets for help on using tickets.