Ticket #826 (closed enhancement: fixed)

Opened 2 years ago

Last modified 5 months ago

[raster] By default, raster2pgsql should not pad tiles with NODATA

Reported by: pracine Owned by: dustymugs
Priority: high Milestone: PostGIS 2.1.0
Component: raster Version: trunk
Keywords: history Cc:

Description (last modified by dustymugs) (diff)

This would be as part of the changes described in #2122.

Change History

Changed 2 years ago by pracine

-Another interesting option would allow not loading tiles containing only nodata -Another interesting option would trim complete row or columns of nodata values at the borders of loading tiles

Changed 2 years ago by pracine

  • milestone changed from PostGIS 2.0.0 to PostGIS Raster Future

Changed 18 months ago by dustymugs

  • summary changed from [raster] There should be an option in raster2pgsql.py to prevent completing tiles with nodata to [raster] There should be an option in raster2pgsql to prevent completing tiles with nodata

Changed 15 months ago by pracine

  • milestone changed from PostGIS Raster Future to PostGIS Future

Changed 6 months ago by dustymugs

  • owner changed from pracine to dustymugs
  • priority changed from low to high
  • status changed from new to assigned
  • milestone changed from PostGIS Future to PostGIS 2.1.0

Changed 6 months ago by dustymugs

  • summary changed from [raster] There should be an option in raster2pgsql to prevent completing tiles with nodata to [raster] raster2pgsql should not pad tiles with NODATA

Changed 6 months ago by dustymugs

  • description modified (diff)

Changed 6 months ago by pracine

So I guess the default behaviour now will be to NOT pad. Do we need an option to pad? I would say yes...

Changed 6 months ago by dustymugs

But what reason is there to pad? Especially if the specs indicate that the width/height of the right and bottom edge tiles can be smaller?

Changed 6 months ago by pracine

The code for padding is there already. It would be a waste to just throw it away. Some people might not mind about keeping the former raster extent and want a nice and clean raster coverage with all the tiles the same size. It make client read more simple. Mat wanted simplicity AND keeping the original extent. You can't have both. And "The reality is that none of us will ever know how PostGIS raster will be used" :-)

Changed 6 months ago by dustymugs

Actually, no. There was no code FOR padding tiles. I had to add code to my git repo to get no padding.

Changed 6 months ago by dustymugs

As a followup, there IS code in ST_Tile though that made sure to support padding when generating tiles.

Changed 6 months ago by dustymugs

Gah. I'm tired of this. I'll add a -P flag indicating that tiles should be padded if needed.

Changed 6 months ago by dustymugs

  • summary changed from [raster] raster2pgsql should not pad tiles with NODATA to [raster] By default, raster2pgsql should not pad tiles with NODATA

Changed 5 months ago by dustymugs

  • keywords history added
  • status changed from assigned to closed
  • resolution set to fixed

Added in r10829.

Note: See TracTickets for help on using tickets.