Opened 8 years ago

Closed 6 years ago

#826 closed enhancement (fixed)

[raster] By default, raster2pgsql should not pad tiles with NODATA

Reported by: pracine Owned by: Bborie Park
Priority: high Milestone: PostGIS 2.1.0
Component: raster Version: trunk
Keywords: history Cc:

Description (last modified by Bborie Park)

This would be as part of the changes described in #2122.

Change History (15)

comment:1 Changed 8 years ago by pracine

-Another interesting option would allow not loading tiles containing only nodata -Another interesting option would trim complete row or columns of nodata values at the borders of loading tiles

comment:2 Changed 8 years ago by pracine

Milestone: PostGIS 2.0.0PostGIS Raster Future

comment:3 Changed 7 years ago by Bborie Park

Summary: [raster] There should be an option in raster2pgsql.py to prevent completing tiles with nodata[raster] There should be an option in raster2pgsql to prevent completing tiles with nodata

comment:4 Changed 7 years ago by pracine

Milestone: PostGIS Raster FuturePostGIS Future

comment:5 Changed 6 years ago by Bborie Park

Milestone: PostGIS FuturePostGIS 2.1.0
Owner: changed from pracine to Bborie Park
Priority: lowhigh
Status: newassigned

comment:6 Changed 6 years ago by Bborie Park

Summary: [raster] There should be an option in raster2pgsql to prevent completing tiles with nodata[raster] raster2pgsql should not pad tiles with NODATA

comment:7 Changed 6 years ago by Bborie Park

Description: modified (diff)

comment:8 Changed 6 years ago by pracine

So I guess the default behaviour now will be to NOT pad. Do we need an option to pad? I would say yes...

comment:9 Changed 6 years ago by Bborie Park

But what reason is there to pad? Especially if the specs indicate that the width/height of the right and bottom edge tiles can be smaller?

comment:10 Changed 6 years ago by pracine

The code for padding is there already. It would be a waste to just throw it away. Some people might not mind about keeping the former raster extent and want a nice and clean raster coverage with all the tiles the same size. It make client read more simple. Mat wanted simplicity AND keeping the original extent. You can't have both. And "The reality is that none of us will ever know how PostGIS raster will be used" :-)

comment:11 Changed 6 years ago by Bborie Park

Actually, no. There was no code FOR padding tiles. I had to add code to my git repo to get no padding.

comment:12 Changed 6 years ago by Bborie Park

As a followup, there IS code in ST_Tile though that made sure to support padding when generating tiles.

comment:13 Changed 6 years ago by Bborie Park

Gah. I'm tired of this. I'll add a -P flag indicating that tiles should be padded if needed.

comment:14 Changed 6 years ago by Bborie Park

Summary: [raster] raster2pgsql should not pad tiles with NODATA[raster] By default, raster2pgsql should not pad tiles with NODATA

comment:15 Changed 6 years ago by Bborie Park

Keywords: history added
Resolution: fixed
Status: assignedclosed

Added in r10829.

Note: See TracTickets for help on using tickets.