topology regression testsuite: localized messages raise false positives

[aperi2007]

Hi, compiling the trunk r I see an error in make check of createtopogeom. Attach the logs.

[aperi2007]

log errors

[strk]

Please try 'make clean all check' from top-level dir.

[aperi2007]

log erorr after make clean all check

[aperi2007]

Replying to strk:

Please try 'make clean all check' from top-level dir.

I try, but still error

log attached

[strk]

Ah! localization problem:

-PL/pgSQL function "createtopogeom" line 91 at EXECUTE statement
+funzione PL/pgSQL "createtopogeom" linea 91 a istruzione EXECUTE

Weird, as the run_test script sets LC_ALL=C Do you have LANG defined ? Or some other localization variable ?

[strk]

It's weird because the db creation log does speak english instead:

psql:/home/postgres/software/postgis/postgis-2.0.0SVN/regress/../topology/topology.sql:3019: NOTICE:  aggregate topology.topoelementarray_agg(topology.topoelement) does not exist, skipping

[aperi2007]

Replying to strk:

Ah! localization problem:

-PL/pgSQL function "createtopogeom" line 91 at EXECUTE statement
+funzione PL/pgSQL "createtopogeom" linea 91 a istruzione EXECUTE

Weird, as the run_test script sets LC_ALL=C Do you have LANG defined ? Or some other localization variable ?

yes, in the shell there is LANG=it_IT.UTF-8

[strk]

can you please try setting LANG=C ?

[aperi2007]

I try setting export LANG=C in the shell. After start postgres db and run make clean all check, always in the same shell. But still the error is here. log attach.

[aperi2007]

log error with lang=C

[strk]

Try running: $ env | grep it_IT and paste the result

[aperi2007]

Replying to strk:

Try running: $ env | grep it_IT and paste the result

Here the result.

postgres@deb:~$ env | grep it_IT LANG=it_IT.UTF-8 postgres@deb:~$

[strk]

There's nothing else then. Please try with r6786

[strk]

Assuming fixed …

[aperi2007]

Hi, I'm having still this error I don't know if it is a false positive. I guess it was never disappear.

I add my log error.

[aperi2007]

two error log files

[aperi2007]

I don't sure to understand what error was issuing. I see this error message.

 regress/createtopogeom. failed (diff expected obtained: /tmp/pgis_reg_9628/test_16_diff)
Run tests: 21
Failed: 1
make[2]: *** [check] Error 1
make[2]: Leaving directory `/home/postgres/software/postgis/postgis-2.0.0SVN/topology/test'
make[1]: *** [check] Error 2
make[1]: Leaving directory `/home/postgres/software/postgis/postgis-2.0.0SVN/topology'
make: *** [check] Error 1

But the logs generated are two "pgis_reg_5400 " and "pgis_reg_9628" I put both in the zip added.

[strk]

checked, but it's still a localization issue. Does: env | grep it return anything else ?

[strk]

Please consider appending RUNTESTFLAGS=-v to your 'make check' call next time:

make check RUNESTFLAGS=-v

That way you would get errors inline and avoid attachements.

[strk]

Andrea: could you please try with r8555 ?

[strk]

r9088 may have made this even stronger. Andrea: chances you can test again?

[aperi2007]

I try it.

It work for me.

close the ticket.