Opened 13 years ago

Closed 13 years ago

#715 closed defect (fixed)

Online regression failures don't stop 'make check'

Reported by: pramsey Owned by: strk
Priority: medium Milestone: PostGIS 2.0.0
Component: postgis Version: master
Keywords: Cc:

Description

When I run 'make check' with the current r6417 build system, the 'make check' does not stop when the online regression tests have a failure, it just moves merrily on to do make check in liblwgeom (which is the reverse of the old order, BTW, which I preferred: first liblwgeom, then online).

Change History (6)

comment:1 by strk, 13 years ago

See how you like r6418

comment:2 by pramsey, 13 years ago

It didn't stop on failure, and it ran the online regressions twice! (I like the return to the original order though :)

comment:3 by strk, 13 years ago

Duplication is gone as of r6420

comment:4 by strk, 13 years ago

I don't see run_test script ever exiting with non-success state. Guess it never stopped on error ?

comment:5 by strk, 13 years ago

r6421 improves run_test to exit 1 on the presence of any failure and 0 otherwise. (how silly, could return number of failures directly… expect a new revision soon)

comment:6 by strk, 13 years ago

Resolution: → fixed
Status: new → closed

there, r6422 is the definitive test runner :>

Note: See TracTickets for help on using tickets.