Ticket #715 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Online regression failures don't stop 'make check'

Reported by: pramsey Owned by: strk
Priority: medium Milestone: PostGIS 2.0.0
Component: postgis Version: trunk
Keywords: Cc:

Description

When I run 'make check' with the current r6417 build system, the 'make check' does not stop when the online regression tests have a failure, it just moves merrily on to do make check in liblwgeom (which is the reverse of the old order, BTW, which I preferred: first liblwgeom, then online).

Change History

Changed 2 years ago by strk

See how you like r6418

Changed 2 years ago by pramsey

It didn't stop on failure, and it ran the online regressions twice! (I like the return to the original order though :)

Changed 2 years ago by strk

Duplication is gone as of r6420

Changed 2 years ago by strk

I don't see run_test script ever exiting with non-success state. Guess it never stopped on error ?

Changed 2 years ago by strk

r6421 improves run_test to exit 1 on the presence of any failure and 0 otherwise. (how silly, could return number of failures directly... expect a new revision soon)

Changed 2 years ago by strk

  • status changed from new to closed
  • resolution set to fixed

there, r6422 is the definitive test runner :>

Note: See TracTickets for help on using tickets.