Opened 13 years ago

Closed 13 years ago

#708 closed defect (fixed)

ST_ExteriorRing POLYGON EMPTY crash

Reported by: robe Owned by: pramsey
Priority: medium Milestone: PostGIS 2.0.0
Component: postgis Version: master
Keywords: Cc:

Description (last modified by robe)

SELECT ST_ExteriorRing(ST_GeomFromText('POLYGON EMPTY',4326)) As result;

Which I think is the cause of ST_DumpPoints crashing as well

SELECT ST_DumpPoints(ST_GeomFromText('POLYGON EMPTY',4326)) As result;

Change History (6)

comment:1 by yabo, 13 years ago

Duplicate of #666. I attached a patch over there.

comment:2 by robe, 13 years ago

I don't think it's a duplicate call. I thought about it when I placed it. That other call was for NULL and PostGIS 1.5 doesn't crash when given the above query. So the crashing is a result of changes in PostGIS 2.0.

Paul — sorry I think I might have missed this one since there wa a bug in my test.

comment:3 by yabo, 13 years ago

Sorry for reading too fast. So where do you think the problem might be? The patch I attached in #666 handles NULL and EMPTY geometries in ST_DumpPoints.

comment:4 by robe, 13 years ago

Description: modified (diff)
Summary: ST_DumpPoints POLYGON EMPTY crashST_ExteriorRing POLYGON EMPTY crash

Maxime, I think ST_DumpPoints is breaking by virtue of the fact that ST_ExteriorRing is the real culprit and it uses that when it sees a polygon type.

comment:5 by robe, 13 years ago

Paul,

any chance you can take care of this one while you are taking off the bandages. I can't get thru my 1.5 regression tests since this keeps crashing.

Though may be a non-issue with gserialized on. Can't recall and not near a gserialized build at the moment.

comment:6 by pramsey, 13 years ago

Resolution: fixed
Status: newclosed

Fixed at r6538

Note: See TracTickets for help on using tickets.