shp2pgsql uses the wrong return type for pgis_getopt

[ssinger]

pgis_getopt is defined to return an int (like a normal getopt).

However in shp2pgsql-cli and -gui the value is being stored as a char.

The compiler then promotes this char back to an int to compare with EOF. The promotion of a char to an int with respect to negative numbers differs based on hardware platform. On powerpc the ((char)-1) != -1

If we store the result of pgis_getopt as an int we avoid this issue.

Patch attached.

[ssinger]

patch to fix the bug

[jadams]

Fixed on trunk in revision 6935. Not fixed on 1.5 yet.

[pramsey]

r9206 in 1.5 branch