regress/core/delaunaytriangles failure

[Bas Couwenberg]

During the transition to GDAL 3.8.0 PostGIS failed to build due to test failures:

 /build/postgis-3.4.0+dfsg/regress/core/delaunaytriangles .. failed (diff expected obtained: /tmp/pgis_reg/test_102_diff)
-----------------------------------------------------------------------------
--- ./regress/core/delaunaytriangles_expected   2023-08-16 02:06:05.000000000 +0000
+++ /tmp/pgis_reg/test_102_out  2023-11-17 14:53:58.110005799 +0000
@@ -1,9 +1,9 @@
-1|GEOMETRYCOLLECTION(POLYGON((5 5,6 0,7 9,5 5)))
-2|GEOMETRYCOLLECTION(POLYGON((5 5,6 0,8 9,5 5)),POLYGON((5 5,8 9,7 9,5 5)))
-3|GEOMETRYCOLLECTION(POLYGON((5 5,6 0,7 9,5 5)))
+1|GEOMETRYCOLLECTION(POLYGON((7 9,5 5,6 0,7 9)))
+2|GEOMETRYCOLLECTION(POLYGON((7 9,5 5,8 9,7 9)),POLYGON((8 9,5 5,6 0,8 9)))
+3|GEOMETRYCOLLECTION(POLYGON((7 9,5 5,6 0,7 9)))
 4|MULTILINESTRING((5 5,7 9),(5 5,6 0),(6 0,7 9))
-5|TIN(((5 5,6 0,7 9,5 5)))
-6|TIN(((5 5,6 0,8 9,5 5)),((5 5,8 9,7 9,5 5)))
-7|TIN(((5 5,6 0,7 9,5 5)))
-10|GEOMETRYCOLLECTION Z (POLYGON Z ((5 5 3,6 0 2,7 9 1,5 5 3)))
-11|TIN Z (((5 5 1,6 0 2,7 9 3,5 5 1)))
+5|TIN(((7 9,5 5,6 0,7 9)))
+6|TIN(((7 9,5 5,8 9,7 9)),((8 9,5 5,6 0,8 9)))
+7|TIN(((7 9,5 5,6 0,7 9)))
+10|GEOMETRYCOLLECTION Z (POLYGON Z ((7 9 1,5 5 3,6 0 2,7 9 1)))
+11|TIN Z (((7 9 3,5 5 1,6 0 2,7 9 3)))
-----------------------------------------------------------------------------

Full buildlogs: ​arm64, ​armel, ​armhf

Since the previous build the following dependencies changed:

PostgreSQL 16.0 (Debian 16.0-2)
PostgreSQL 16.1 (Debian 16.1-1)

GEOS: 3.12.0-CAPI-1.18.0
GEOS: 3.12.1-CAPI-1.18.1

SFCGAL: 1.4.1
SFCGAL: 1.5.0

GDAL: GDAL 3.7.2
GDAL: GDAL 3.8.0

[robe]

./regress/core/delaunaytriangles_expected doesn't use GDAL at all so that would be strictly a GEOS issue. Looks like strk already patched this issue at [1cebea67/git]

The delaunaytriangles was a result of order changes in the micro releases of GEOS. So they should all disappear once we release 3.4.1, which should hopefully be soon.

Can you test with [1cebea67/git] patch and confirm it fixes your issue?

[Bas Couwenberg]

Confirmed fixed with the changes from ​https://trac.osgeo.org/postgis/changeset/1cebea67/git