Populate_Geometry_Columns should declare type to be 'GEOMETRY' when failing to apply geotype constraint

[kneufeld]

A table with mixed geometry types obviously can't have an enforce_geotype constraint applied to the table, but geometry_columns should still have a valid record indicating the geometry type. In this case, perhaps 'GEOMETRY' or 'MIXED'.

At the moment, this function declares the type in geometry_columns to be the first geometrytype detected in the table, which is not correct.

create table foo(geom geometry);
insert into foo values ('POINT(0 0)'::geometry);
insert into foo values ('LINESTRING(0 0, 1 1)'::geometry);
select populate_geometry_columns();
select * from geometry_columns ;

 f_table_catalog | f_table_schema | f_table_name | f_geometry_column | coord_dimension | srid | type  
-----------------+----------------+--------------+-------------------+-----------------+------+-------
                 | public         | foo          | geom              |               2 |   -1 | POINT
(1 row)

[pramsey]

No love, no fix.