Ticket #356 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Get rid of logging of password in shp2pgsql-gui

Reported by: robe Owned by: pramsey
Priority: medium Milestone: PostGIS 1.5.0
Component: postgis Version: trunk
Keywords: Cc:

Description

This is a minor gripe, but can we not log passwords on the logging window. It is particularly annoying if you are trying to do a demo.

Attachments

guishot.png Download (20.8 KB) - added by robe 2 years ago.
Okay here it is -- I have already changed my password

Change History

Changed 2 years ago by pramsey

Can you post a screenshot? This doesn't ring any bells with me.

Changed 2 years ago by robe

Okay here it is -- I have already changed my password

Changed 2 years ago by pramsey

  • status changed from new to closed
  • resolution set to fixed

Awesome, I totally rock. Good catch, replaced with a sanitized version at r5052.

Changed 2 years ago by robe

  • status changed from closed to reopened
  • resolution fixed deleted

I think you missed a spot. I see asterisks now when I do test connection, but when I do import, I still see my unsanitized password on the first line of import.

Changed 2 years ago by pramsey

  • status changed from reopened to closed
  • resolution set to fixed

Merry Christmas! r5054

Changed 2 years ago by robe

  • status changed from closed to reopened
  • resolution fixed deleted

Only seems to do it when I click test connection. I thought we had fixed it before but seems to be an issue again.

Changed 2 years ago by pramsey

  • status changed from reopened to closed
  • resolution set to fixed

Yeah, I'm sure we had this fixed. I'm going to trace back and see if/how it got changed again. Anyhow, fixed (again?) at r5095

Changed 2 years ago by pramsey

Looking back, I broke the connection test case when I fixed actual import run case. I guess we just didn't notice it at the time.

Note: See TracTickets for help on using tickets.