#3165 closed defect (fixed)
make_dist.sh should allow for custom configure
| Reported by: | robe | Owned by: | strk |
|---|---|---|---|
| Priority: | medium | Milestone: | PostGIS 2.2.2 |
| Component: | build | Version: | master |
| Keywords: | Cc: | gdt |
Description
Right now whenever I make a change to make_dist.sh I can't test it cause all my dependencies are in custom locations passed in via
./configure
make_dist.sh just calls configure though.
Debbie has the same issue, so have a custom make_dist for her.
It would be nice if make_dist was either smart enough to use what was used, or allow for passing in of args
Change History (9)
comment:1 by , 8 years ago
comment:2 by , 8 years ago
| Cc: | added |
|---|
I'm a bit concerned about the possibility to build different tarballs based on configure switches, so I think we should really focus on why it is needed to run configure at all, for the purpose of creating the tarball.
I _think_ (but should be checked) it is about creating the documentation, so to include it in the tarball, is this the case ?
To be honest I'm not even sure we should be doing this, rather than simply run ./autogen.sh and be done.
Comments from other packagers ?
comment:3 by , 8 years ago
no. We have a separate job for creating the documentation. The documentation is not included built in the tarball. Only thing built from the docs included in the tarball are the postgis comments sql files which really only needs xsltproc to be found.
comment:4 by , 8 years ago
Good point about having to run configure being an sign of trouble, and better to fix than to work around. I was really just trying to go down a "use standard procedure to make tarball" path, not to push which way it should be.
I wonder if it would be reasonable to just separate the comments build and just do that, and expect that xsltproc is in PATH, without checking for it. And thus not run configure.n
Longer term, perhaps comments should be built at build time, not at tarball time.
comment:5 by , 8 years ago
Sorry, put patch in wrong ticket. Please see https://trac.osgeo.org/postgis/ticket/3482#comment:13
comment:6 by , 8 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:8 by , 8 years ago
Just for perspective, only reason we include the comments is because some people don't have xsltproc and the comments are needed since they are part of the extension script.
I am having the same problem, and the first symptom is not finding proj. This could be worked around by having proj looked for in the search path; I do pass in CPPFLAGS/LDFLAGS in the environment. But that won't solve the general issues.
I wonder if the configure options used to build postgis can be extracted from config.status and then used.