Opened 4 years ago

Closed 4 years ago

#2942 closed defect (fixed)

topology intersects function not compatible with latest 9.5 dev

Reported by: robe Owned by: strk
Priority: blocker Milestone: PostGIS 2.1.5
Component: topology Version: 2.1.x
Keywords: Cc:

Description (last modified by robe)

Debbie just screamed in her weekend 9.5 run. It seems they changed something in 9.5 code base that is incompatible with topology. Probably a bit too early to be alarmed but we should keep an eye on it.

psql:/var/lib/jenkins/workspace/postgis/regress_pgdev/branches/2.2/regress/00-regress-install/share/contrib/postgis/topology.sql:2667: ERROR:  too many parameters specified for RAISE
CONTEXT:  compilation of PL/pgSQL function "intersects" near line 201

Change History (11)

comment:1 Changed 4 years ago by robe

Description: modified (diff)

comment:2 Changed 4 years ago by robe

Actually I think 9.5 has right to complain. I just noticed this call in intersects function.

 RAISE EXCEPTION 'Invalid TopoGeometry type', tg2.type;

I guess earlier versions of Postgres are just ignoring the fact that you aren't using tg2.type in your exception.

comment:3 Changed 4 years ago by robe

Noticed this one too

RAISE EXCEPTION 'Intersection line/collection not implemented yet', tg1.type, tg2.type;

Ah this function has a number of these mistakes.

comment:4 Changed 4 years ago by robe

Summary: topology not compatible with latest 9.5 devtopology intersects function not compatible with latest 9.5 dev

comment:5 Changed 4 years ago by robe

Priority: mediumblocker

comment:6 Changed 4 years ago by robe

Milestone: PostGIS 2.2.0PostGIS 2.1.5

comment:7 Changed 4 years ago by strk

Fixed those that I found with r13005 in trunk. Once debbie is happy I'll backport. (a link to debbie here would be useful)

comment:8 Changed 4 years ago by strk

Debbie build was ok, but it did not include 9.5: http://debbie.postgis.net:8080/job/PostGIS_2.2/579/ -- how to trigger a test against 9.5 ?

comment:9 Changed 4 years ago by robe

She only tests 9.5 on weekends after pulling down rebuilding the latest PostgreSQL 9.5 dev tar ball -- is the job http://debbie.postgis.net:8080/job/PostGIS_Regress_PGDEV_Weekly

which you can manually trigger (if you log in :) ) or if you can't remember your login I can retrigger when you are ready.

comment:10 Changed 4 years ago by strk

I'm ready, but don't remember my password (or I never registered)

comment:11 Changed 4 years ago by strk

Resolution: fixed
Status: newclosed
Version: trunk2.1.x
Note: See TracTickets for help on using tickets.