Bad geometry created from ST_AddPoint

[Mike Taves]

Found this bug here ​http://stackoverflow.com/q/24812031/327026

Simplified as:

drop table bug;
create table bug(geom geometry(LineString));
insert into bug(geom) values('LINESTRING(0 0, 1 1)');
update bug set geom = ST_AddPoint(geom, 'POINT(3 3)');

select ST_Intersects(geom, box), ST_Intersects(geom::text::geometry, box)
from bug, (
  select 'POLYGON ((2 2, 2 4, 4 4, 4 2, 2 2))'::geometry AS box
 ) AS foo;

with nonsense results, which should both be TRUE:

 st_intersects | st_intersects
---------------+---------------
 f             | t

Note that using ST_MakeLine in place of ST_AddPoint in the above update query has expected results.

[pramsey]

Fixed in 2.0 at r12848, 2.1 at r12850, trunk at r12849