#2754 closed patch (fixed)
need postgis_sfcgal wrapped as an extension
Reported by: | robe | Owned by: | robe |
---|---|---|---|
Priority: | blocker | Milestone: | PostGIS 2.2.0 |
Component: | sfcgal | Version: | master |
Keywords: | history | Cc: |
Description
right now the sfcgal.sql file is loose and requires separate manual handling.
This should be wrapped up as an extension to be installed similar to what we have with postgis_topology and postgis_tiger_geocoder.
Attachments (2)
Change History (8)
comment:1 by , 10 years ago
Type: | defect → enhancement |
---|
by , 10 years ago
Attachment: | 2754.patch added |
---|
comment:2 by , 10 years ago
Owner: | changed from | to
---|
vmo changes I would make
Change:
MINORVERSION = 2011.@POSTGIS_MAJOR_VERSION@.@POSTGIS_MINOR_VERSION@
to
MINORVERSION = @POSTGIS_MAJOR_VERSION@.@POSTGIS_MINOR_VERSION@
get rid of requirement that it be installed in sfcgal schema. I think most people are just going to want to install it in the same schema as they install PostGIS especially since some of the functions PostGIS provides it supplants.
sql/sfcgal_upgrade_minor.sql build step use an upgrade minor script built by perl script strk has largely changed which can read availability info etc. This will make it less likely to be mangled by Sun Solaris sed, and also better able to handle Aggregates once you start adding those. I'm not sure if the perl script http://trac.osgeo.org/postgis/browser/trunk/utils/postgis_proc_upgrade.pl
needs some changing though. For now what you have is fine since functions should always be replaced and that is all you have so far.
by , 10 years ago
Attachment: | 2754_1.patch added |
---|
comment:4 by , 10 years ago
Type: | enhancement → patch |
---|
comment:5 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:6 by , 10 years ago
Keywords: | history added |
---|
creates postgis_sfcgal extension