Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2754 closed patch (fixed)

need postgis_sfcgal wrapped as an extension

Reported by: robe Owned by: robe
Priority: blocker Milestone: PostGIS 2.2.0
Component: sfcgal Version: trunk
Keywords: history Cc:

Description

right now the sfcgal.sql file is loose and requires separate manual handling.

This should be wrapped up as an extension to be installed similar to what we have with postgis_topology and postgis_tiger_geocoder.

Attachments (2)

2754.patch (6.7 KB) - added by vmo 5 years ago.
creates postgis_sfcgal extension
2754_1.patch (7.6 KB) - added by vmo 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 5 years ago by strk

Type: defectenhancement

Changed 5 years ago by vmo

Attachment: 2754.patch added

creates postgis_sfcgal extension

comment:2 Changed 5 years ago by robe

Owner: changed from robe to vmo

vmo changes I would make

Change:

MINORVERSION  = 2011.@POSTGIS_MAJOR_VERSION@.@POSTGIS_MINOR_VERSION@ 

to

MINORVERSION  = @POSTGIS_MAJOR_VERSION@.@POSTGIS_MINOR_VERSION@ 

get rid of requirement that it be installed in sfcgal schema. I think most people are just going to want to install it in the same schema as they install PostGIS especially since some of the functions PostGIS provides it supplants.

sql/sfcgal_upgrade_minor.sql build step use an upgrade minor script built by perl script strk has largely changed which can read availability info etc. This will make it less likely to be mangled by Sun Solaris sed, and also better able to handle Aggregates once you start adding those. I'm not sure if the perl script http://trac.osgeo.org/postgis/browser/trunk/utils/postgis_proc_upgrade.pl

needs some changing though. For now what you have is fine since functions should always be replaced and that is all you have so far.

comment:3 Changed 5 years ago by vmo

Owner: changed from vmo to robe

robe, I made all required changes.

Changed 5 years ago by vmo

Attachment: 2754_1.patch added

comment:4 Changed 5 years ago by robe

Type: enhancementpatch

comment:5 Changed 5 years ago by robe

Resolution: fixed
Status: newclosed

committed at r12690 and r12689. Missed folder first time around.

I left out your change to postgis.control.in (where you changed the description to PostGIS SFCGAL functions). I assume that was a mistake.

comment:6 Changed 5 years ago by robe

Keywords: history added
Note: See TracTickets for help on using tickets.