Deprecate all functions with underscore_names rather than CamelCase

[strk]

Spin-off of #1994, for those still not deprecated.

    ST_Shift_Longitude(geometry)
    ST_Combine_BBox(box2d,geometry)
    ST_find_extent(text,text,text) RETURNS box2d AS
    ST_find_extent(text,text) RETURNS box2d AS
    ST_mem_size(geometry)
    ST_3DLength_spheroid(geometry, spheroid)
    ST_length_spheroid(geometry, spheroid)
    ST_length2d_spheroid(geometry, spheroid)
    ST_distance_spheroid(geom1 geometry, geom2 geometry,spheroid)
    ST_point_inside_circle(geometry,float8,float8,float8)
    ST_locate_between_measures(geometry, float8, float8)
    ST_locate_along_measure(geometry, float8)
    ST_Combine_BBox(box3d,geometry)
    ST_distance_sphere(geom1 geometry, geom2 geometry)
    ST_distance_sphere(geom1 geometry, geom2 geometry) 

[strk]

These are deprecated with r13172:

ST_Shift_Longitude(geometry) ST_Combine_BBox(box2d,geometry) ST_Combine_BBox(box3d,geometry) ST_find_extent(text,text,text) RETURNS box2d AS ST_find_extent(text,text) RETURNS box2d AS

Already deprecated with r12629 (2.2.0dev):

ST_mem_size(geometry)

Left over:

ST_3DLength_spheroid(geometry, spheroid) ST_length_spheroid(geometry, spheroid) ST_length2d_spheroid(geometry, spheroid) ST_distance_spheroid(geom1 geometry, geom2 geometry,spheroid) ST_point_inside_circle(geometry,float8,float8,float8) ST_locate_between_measures(geometry, float8, float8) ST_locate_along_measure(geometry, float8) ST_distance_sphere(geom1 geometry, geom2 geometry) ST_distance_sphere(geom1 geometry, geom2 geometry)

[strk]

With proper formatting, leftovers:

ST_3DLength_spheroid(geometry, spheroid) 
ST_length_spheroid(geometry, spheroid)
ST_length2d_spheroid(geometry, spheroid)
ST_distance_spheroid(geom1 geometry, geom2 geometry,spheroid)
ST_point_inside_circle(geometry,float8,float8,float8)
ST_locate_between_measures(geometry, float8, float8)
ST_locate_along_measure(geometry, float8)
ST_distance_sphere(geom1 geometry, geom2 geometry)
ST_distance_sphere(geom1 geometry, geom2 geometry) 

[strk]

Done with r13173:

• ST_length_spheroid(geometry, spheroid)
• ST_distance_spheroid(geom1 geometry, geom2 geometry,spheroid)

Left over:

• ST_distance_sphere(geom1 geometry, geom2 geometry)
• ST_3DLength_spheroid(geometry, spheroid)
• ST_length2d_spheroid(geometry, spheroid)
• ST_point_inside_circle(geometry,float8,float8,float8)
• ST_locate_between_measures(geometry, float8, float8)
• ST_locate_along_measure(geometry, float8)

[strk]

r13179 does ST_DistanceSphere, left over:

• ST_3DLength_spheroid(geometry, spheroid)
• ST_length2d_spheroid(geometry, spheroid)
• ST_point_inside_circle(geometry,float8,float8,float8)
• ST_locate_between_measures(geometry, float8, float8)
• ST_locate_along_measure(geometry, float8)

[strk]

r13192 deprecates ST_3DLength_Spheroid, left over:

• ST_length2d_spheroid(geometry, spheroid)
• ST_point_inside_circle(geometry,float8,float8,float8)
• ST_locate_between_measures(geometry, float8, float8)
• ST_locate_along_measure(geometry, float8)

[strk]

we're almost there, better not leave this half-finished

[strk]

The ST_Length2d_Spheroid is currently NOT DOCUMENTED. There's documentation for ST_LengthSpheroid and ST_3DLengthSpheroid, do we also need ST_2DLengthSpheroid ?

[strk]

r13488 deprecates ST_Point_Inside_Circle (in favor of ST_PointInsideCircle), left over:

• ST_Length2d_Spheroid(geometry,spheroid) — should it be ST_2DLengthSpheroid ? We have ST_LengthSpheroid and ST_3DLengthSpheroid
• ST_Locate_Between_Measures(geometry,float8,float8) — is already advertised as deprecated, using NOTICE (rather than WARNING). Results seem incompatible with any existing name so cannot be changed to an SQL wrapper (unless Paul knows how).
• ST_Locate_Along_MEasure(geometry,float8,float8) — is already advertised as deprecated, using NOTICE (rather than WARNING). Results seem incompatible with any existing name so cannot be changed to an SQL wrapper (unless Paul knows how).

[strk]

r13506 makes the deprecation of ST_Locate_Between_Measures and ST_Locate_Along_Measure closer in style to that of other deprecations. That is, is reported via WARNING (deprecation happened in 2.0.0) and explicitly states the version in which it was deprecated. It's still not done using _postgis_deprecate because behavior can be different.

So now the only left is ST_Length2d_Spheroid. Ideas on how it should be called, for consistency ? ST_LengthSpheroid does 2d or 3d based on input, ST_3DLengthSpheroid does exactly the same thing. And, actually… ST_Length2d_Spheroid also does take Z into account !!!

Proposal: deprecate all but ST_LengthSpheroid. What do you think ?

[strk]

Still, documentation says that ST_Length2D_Spheroid would drop the Z, but it doesn't: ​http://postgis.net/docs/ST_Length2D_Spheroid.html

pg21=# select ST_Length2d_Spheroid('LINESTRING(0 0 0, 0 0 1000)'::geometry, 'SPHEROID["GRS_1980",6378137,298.257222101]');
 st_length2d_spheroid 
----------------------
                 1000
(1 row)

[strk]

Another documentation issue: it is not true that those functions will return 0 for anything not a linestring/multilinestring :/

[strk]

r13507 takes care of ST_Length2D_Spheroid, renaming it to ST_Length2DSpheroid and fixing the 2d enforcement. This ticket is completed.