Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#2661 closed defect (fixed)

st_astwkb_agg(geometry,int) needs code comment and violates naming convention

Reported by: robe Owned by: robe
Priority: medium Milestone: PostGIS 2.2.0
Component: postgis Version: master
Keywords: Cc:

Description

1) the new aggregate function ST_AsTWKB_Agg should be called ST_AsTWKBAgg to be consistent with the naming convention in postgis proper (I know tiger geocoder breaks all those rules, but my excuse for that is it was like that when I got there and its a separate extension :) ).

2) Now with strk's new work in the postgis upgrade routine, aggregate functions that are not commented as new, will not be installed. Refer to #2659

So the aggregates (actually all things) should have a comment at top of definition of form:

-- Availability: 2.2.0
CREATE AGGREGATE st_astwkbagg(geometry,int) (

Change History (3)

comment:1 by robe, 10 years ago

Owner: changed from nicklas to robe

comment:2 by robe, 10 years ago

Resolution: fixed
Status: newclosed

fixed at r12293

comment:3 by nicklas, 10 years ago

Thank you Regina

I intended to do it when I saw the ticket but I was to slow.

Thanks :-)

Note: See TracTickets for help on using tickets.