AddNode(atopology, apoint) redundant

[robe]

In looking at functions that aren't documented, I noticed we have

topology.addnode(atopology character varying, apoint geometry)

The reason it isn't documented is our docs say

 topology.addnode(atopology character varying, apoint geometry, allowedgesplitting boolean DEFAULT false, setcontainingface boolean DEFAULT false)

but the actual implementation is

 topology.addnode(atopology character varying, apoint geometry, allowedgesplitting boolean, setcontainingface boolean DEFAULT false)

We should probably clean this up in 2.2. Probably not worthwhile to fix in 2.½.0. In the end it will be the same, just one less function.

[strk]

That's the result of my lazy way to deal with upgrades. Adding an optional parameter doesn't replace the old signature, so in order to do a clean upgrade you'd have to _drop_ the previous, which is not something you do in an install file.

When I'm willing to provide a single .sql to do both install and upgrade (because I'm lazy) that's what I do: never drop any signature, and if I need more parameters keep the old one as wrappers that call the new one passing the defaults. This has been working since PostGIS-1.0 against PostgreSQL 6.X …

Keep it simple!

[robe]

we drop old ones in postgis proper when we define new with defaults.

I like fewer functions. That's more kissy to me

[strk]

This would involve adding a _drop file for topology, augmenting complexity. I don't feel any urge for that.

[robe]

Milestone renamed

[strk]

We DO have a topology_drop_before and topology_drop_after support now, so it may be time to fix this (if still an issue)

[Sandro Santilli <strk@…>]

In fba0330/git:

Do not allow SRID < 0 in the topology.topology schema

References #2592

[strk]

OOps, commit [fba0330289c7ad2ed3cc5642f259940c59beda6b/git] was for #3192, not this ticket

[Sandro Santilli <strk@…>]

In 003080f/git:

Remove redundant AddNode() function

Closes #2592