parse_address('16 Berry Lane, skenectady, ny 12302') is wrong

[woodbri]

The code for separating city from street is not respecting the comma if included.

[woodbri]

I just checked in changes to pagc/branches/sew-refactor/postgresql/ that should fix this problem. Regina will need to pull these changes into postgis.

cd /path/to/pagc/branches/sew-refactor/postgresql/
svn update
make clean
make dist-clean
make
sudo make install
make test  ## explains how to test this

[robe]

I have it just as a link pointing to you repo so assume not much needs to change aside from rebuilding for windows. I think I have winnie set to automatically rebuild but I'll verify before I package up the 2.1.1 windows build.

[robe]

hmm I'm getting this error which I wasn't getting before. I recall you had autogenerated whatever this was before:

/POSTGR~1/rel/PG9~1.3W6/include/internal -I.  -I/projects/pcre/rel-8.33w64gcc48/include "-Ic:/MING64~1/projects/POSTGR~1/rel/PG9~1.3W6/l
cat usps-st-city-orig.txt usps-st-city-adds.txt | sort -u >usps-st-city-name.txt
/bin/perl.exe -c mk-city-regex.pl
Can't locate Regexp/Assemble.pm in @INC (@INC contains: /usr/lib/perl5/5.8/msys /usr/lib/perl5/5.8 /usr/lib/perl5/site_perl/5.8/msys /us
ty-regex.pl line 4.
BEGIN failed--compilation aborted at mk-city-regex.pl line 4.

I assume I'm missing installation fo some perl package and maybe it wasn't an issue before since you pre-built the sql files or something.

[robe]

Fixed by installing Regexp::Assemble — I guess I should add that to the install instructions if people get this error

cpan Regexp::Assemble

and then compiling

[woodbri]

Yes, that is the right thing to do.

I thought we were already using that package, but maybe not. The perl package changed names when the author refactored it. It turns out that then new package is not not compatible with pcre that is used in the C code and I had to modify the generated regexp strings so they worked with pcre.

I created a test file as I mentioned, it might be nice if that could be turned into postgis test in some way. My plan is to expand on the tests over time, but the current file tests that the high level parsing patterns all work at least at a superficial level.

[robe]

I've updated docs at r12074 (for 2.2) and r12073 (for 2.1)