Opened 6 years ago

Closed 3 years ago

Last modified 13 months ago

#2114 closed defect (wontfix)

tiger_2010 loader unzip breaks on some states

Reported by: channelzero Owned by: robe
Priority: medium Milestone: PostGIS Fund Me
Component: tiger geocoder Version: 2.0.x
Keywords: Cc: woodbri

Description

The tiger2010 loader script has the following lines for unzipping the files downloaded by the wget command that precedes it.

for z in *.zip; do $UNZIPTOOL -o -d $TMPDIR $z; done

for z in */*.zip; do $UNZIPTOOL -o -d $TMPDIR $z; done

This doesn't work for Pennsylvania or New Hampshire as both States wget command results in subdirectories with the zipped files. I used the stanza below to fix the issue for New Hampshire and Pennsylvania and commented out the lines above

find $STATEDIR/ -name "*.zip" | while read z; do $UNZIPTOOL -o -d $TMPDIR $z; done

It works for me on the rest of the States. But, I don't know if there are other consequences that I cannot see.

Change History (6)

comment:1 Changed 6 years ago by robe

Milestone: PostGIS 2.0.2PostGIS 2.0.3

I may not get to testing this before 2.0.2 release and don't want this holding it up.

comment:2 Changed 6 years ago by woodbri

Cc: woodbri added

comment:3 Changed 5 years ago by robe

Milestone: PostGIS 2.0.4PostGIS 2.1.0

comment:4 Changed 5 years ago by robe

Milestone: PostGIS 2.1.0PostGIS Future

turns out this is a non-issue for tiger_2011 /tiger_2012 since those are all in a completely flat folder and prefixed by state/county. So would only be a fix at 2.0. Not even sure its worth fixing since people would be better off using the tiger from 2.1 folder which loads tiger 2011/2012 data. so I'm pushing to future and may later mark as won't fix.

comment:5 Changed 3 years ago by robe

Resolution: wontfix
Status: newclosed

comment:6 Changed 13 months ago by robe

Milestone: PostGIS FuturePostGIS Fund Me

Milestone renamed

Note: See TracTickets for help on using tickets.