Can't install trunk on 9.3 instance

[robe]

Just setup a buildbot instance for regressing against 9.3 dev on Debbie.

It compiles but fails to install with this error in logfile:

ERROR:  could not load library "/var/lib/jenkins/workspace/postgis/branches/2.1/regress/00-regress-install/lib/postgis-2.1.so": /var/lib/jenkins/workspace/postgis/branches/2.1/regress/00-regress-install/lib/postgis-2.1.so: undefined symbol: GETSTRUCT

[strk]

mixing postgresql headers ? missing some cleanup ?

[robe]

Hmm don't see why it would be different than 9.1,9.2 they all go thru the same path, so I would expect missing cleanup to affect them as well. Unless it was something wrong with my compile of 9.3, but then I'd expect the service to not start at all.

I'll give it another go.

[robe]

Still same error. You think maybe our make clean is not cleaning everything. They do use the same source folder, so what you are saying is possible if there is something wrong with our cleanup logic.

I'm going to try next on my windows box to confirm I have the same issue.

[dustymugs]

It looks like there are some core API changes in PG 9.3

​http://postgresql.1045698.n5.nabble.com/bugfix-sepgsql-didn-t-follow-the-latest-core-API-changes-td5722337.html

[robe]

So I guess we just have to add an include somewhere to our code? and possibly a conditional one?

[strk]

Yes, possibly. Try it out !

[robe]

Okay when I compile under mingw64 it doesn't even get past compile and gives a more informative description:

c:\ming64\projects\postgis\postgis-2.1.0SVN\postgis/geometry_estimate.c:318: und
efined reference to `GETSTRUCT'
c:\ming64\projects\postgis\postgis-2.1.0SVN\postgis/geometry_estimate.c:330: und
efined reference to `GETSTRUCT'

I'll try to see if I can patch that

[robe]

Fixed at r10320. I had to make conditional since spot checking 9.0, it wouldn't compile since access/htup_details.h doesn't exist.

[robe]

spoke too soon. my conditional is not working. I must have the name wrong or its not included in this file.

[robe]

fixed at r10321