[raster] Index tablespace handing in raster2psql broken

[kib]

I tried using "-X" option for raster2psql but got a PostgreSQL syntax error.

raster2psql in version 2.0.1 outputs the following SQL:

CREATE TABLE "2mt_20120802_00" ("rid" serial PRIMARY KEY,"rast" raster)
USING INDEX TABLESPACE "data"
TABLESPACE "data";

while the correct PostgreSQL 9.1 syntax is:

CREATE TABLE "2mt_20120802_00" ("rid" serial PRIMARY KEY USING INDEX TABLESPACE "data","rast" raster)
TABLESPACE "data";

where as it can be changed to use correct PostgreSQL syntax by changing code in raster/loader/raster2psql.c line 899 to:

sprintf(sql, "CREATE TABLE %s%s (\"rid\" serial PRIMARY KEY%s%s,%s raster%s)%s%s;",
(schema != NULL ? schema : ""),
table,
(idx_tablespace != NULL ? " USING INDEX TABLESPACE " : ""),
(idx_tablespace != NULL ? idx_tablespace : ""),
column,
(file_column ? ",\"filename\" text" : ""),
(tablespace != NULL ? " TABLESPACE " : ""),
(tablespace != NULL ? tablespace : "")
);

[dustymugs]

Fixed in r10121 for 2.0 and r10123 for trunk.