Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#1779 closed defect (fixed)

Make install is not installing comments sql files

Reported by: jomarlla Owned by: strk
Priority: medium Milestone: PostGIS 2.0.1
Component: build/upgrade/install Version: trunk
Keywords: Cc:

Description

"make" builds the comments sql files but "make install" does not install it. One can use "make docs-install" but it shouldn't be necessary.

  • postgis_comments.sql
  • raster_comments.sql
  • topology_comments.sql

The installation of PostGIS 2.0 from repositories for OpenSuse? 12.1 (http://download.opensuse.org/repositories/Application:/Geo/) is not including these comments either.

Didnt check in other Linux distros.

Change History (8)

comment:1 Changed 7 years ago by strk

I noticed that comments are only built by "make" when building extensions. The reason for this is that comments are made part of the postgis extension.

@robe : what's the policy in this case ? we're basically duplicating files around when extensions are enabled or is extension using the same base files as the non-extension model ?

In other words, what should and should not be installed with extensions enabled or disabled ?

comment:2 Changed 6 years ago by robe

strk I don't understand your question. extensions use the generated comments and massages the other generated files to add ALTER EXTENSION and remove things not legal for extensions (like removing the BEGIN / END TRANSACTION) since create extension always runs in its own transaction.

So regular install should install comments files if it creates them or they are available (e.g as should be the case when installing from tar ball).

comment:3 Changed 6 years ago by strk

Robe, the question was: what do you expect to see in the share folder after make install ? I think I can answer myself: everything is "duplicated" in share folder and in extension folder. It is still weird to require comments when building againts 9.1 but not when building against previous postgresql versions.

comment:4 Changed 6 years ago by strk

Resolution: fixed
Status: newclosed

r9885 will install them when possible. r9886 will also build them, always when possible.

comment:5 Changed 6 years ago by strk

r9887 also does it in trunk

comment:6 Changed 6 years ago by robe

comments should be auto packaged with tar ball and should always be installed if building from tar ball. So the only reason one should need to build it is if they are building from svn. I'd be fine with always requiring it for SVN builds, but others might have issues with the xsltproc requirement.

comment:7 Changed 6 years ago by strk

It will not be required by r9885, r9886 and r9887 -- those commits only build and install them IFF xsltproc was found. Anyway, I'll double-check.

comment:8 Changed 6 years ago by strk

Ah, now I see what you mean. If someone fetches a tarball she will have the comments but they won't be installed unless XSLTPROC is found.

r9888 in branch fixes this, always installing comments IF they are available. r9889 in trunk.

Note: See TracTickets for help on using tickets.