Opened 7 years ago

Last modified 21 months ago

#1770 new patch

long transaction

Reported by: cruizch Owned by: cruizch
Priority: medium Milestone: PostGIS Fund Me
Component: postgis Version: 2.0.x
Keywords: long transaction Cc: strk

Description

The long transaction support requires to be cleaned up and updated, this process involves the actualization of the WFS_locks and long_xact SQL code, the function signatures change (to begin with ST_) and the adding of some regression tests.

These changes will only affect the WFS_locks.sql.in and the long_xact.sql.in.c files.

Attachments (1)

patch.zip (5.2 KB) - added by cruizch 7 years ago.
long_xact.sql.in.c and regression tests

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by strk

It seems to me that the long_xact.sql.in.c is a verbatim copy of WFS_locks.sql.in in that case the whole extras/WFS_locks directory should probably die...

comment:2 Changed 7 years ago by cruizch

OK. Just the long_xact.sql.in.c file will be affected. The extras/WFS_locks will be erased by the trunk manager.

comment:3 Changed 7 years ago by strk

I'm thinking that ST_ prefix would be inappropriate because the module has nothing to do with geometries. It provides locking support for _any_ kind of row. A postgis_ one would still make sense to identify the functions as being installed by postgis...

comment:4 Changed 7 years ago by cruizch

Well, all the function signatures will start with postgis_ then.

comment:5 Changed 7 years ago by cruizch

The long_xact.sql.in.c file has been modified with the new function signatures, code cleansing, some function documentation added, and credits from the WFS_locks.sql.in added. Also, three regression tests were created.

Changed 7 years ago by cruizch

Attachment: patch.zip added

long_xact.sql.in.c and regression tests

comment:6 Changed 7 years ago by strk

Milestone: PostGIS 2.0.1PostGIS 2.1.0

comment:7 Changed 6 years ago by robe

Do we have issue with accepting this patch. I don't have need for long transaction support so not a good judge for this.

comment:8 Changed 6 years ago by robe

Milestone: PostGIS 2.1.0PostGIS 2.2.0

comment:9 Changed 4 years ago by strk

Milestone: PostGIS 2.2.0PostGIS 2.3.0
Priority: lowmedium
Type: taskpatch

Pity this hasn't made it into 2.2.0, it has a patch attached !

comment:10 Changed 4 years ago by robe

Yah how did we let it slide. I think part of the reason is that long transaction support used to only be used by geoserver and unless one of us is using geoserver, it's hard to verify the patch doesn't break something. I'm not even sure if geoserver uses that anymore. Not sure if QGIS uses it and that whole long transaction stuff probably needs a closer revisiting so the patch may already be obsolete.

comment:11 Changed 3 years ago by robe

Milestone: PostGIS 2.3.0PostGIS Future

I'm tempted to just mark this as won't fix as I suspect since long transaction support hasn't been touched in ages, it's probably not used anymore otherwise more people would have complained.

comment:12 Changed 21 months ago by robe

Milestone: PostGIS FuturePostGIS Fund Me

Milestone renamed

Note: See TracTickets for help on using tickets.