Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#1719 closed enhancement (fixed)

Add support for Point and GeometryCollection ST_MakeValid inputs

Reported by: strk Owned by: pramsey
Priority: medium Milestone: PostGIS 2.1.0
Component: postgis Version: trunk
Keywords: history Cc:

Description

There's no reason to break out of a transaction only because POINT is not supported by ST_MakeValid... Just return the input point !

Change History (7)

comment:1 Changed 3 years ago by pracine

To double check but I think ST_MakeValid also fails when the geometry is empty. There's no reason to break out of a transaction only because EMPTY is not supported by ST_MakeValid...

comment:2 Changed 3 years ago by strk

  • Summary changed from Add Point support in ST_MakeValid to Do not throw an exception on unsupported ST_MakeValid input

Can't confirm the empty case:

strk=# select ST_AsEWKT(ST_MakeValid('POLYGON EMPTY'));
   st_asewkt   
---------------
 POLYGON EMPTY
(1 row)

But GEOMETRYCOLLECTION is a problem !

trk=# select ST_AsEWKT(ST_MakeValid('GEOMETRYCOLLECTION EMPTY'));
ERROR:  ST_MakeValid: unsupported geometry type GeometryCollection

comment:3 Changed 3 years ago by strk

  • Summary changed from Do not throw an exception on unsupported ST_MakeValid input to Add support for Point and GeometryCollection ST_MakeValid inputs

For the GEOMETRYCOLLECTION type we actually want to _add_ the support, not just return the input

comment:4 Changed 3 years ago by robe

  • Milestone changed from PostGIS 2.0.0 to PostGIS 2.0.1

sounds like a feature to me.

comment:5 Changed 3 years ago by strk

r9554 adds acceptance of points. Note that points are just returned the way they are.

comment:6 Changed 3 years ago by strk

  • Milestone changed from PostGIS 2.0.1 to PostGIS 2.1.0
  • Resolution set to fixed
  • Status changed from new to closed
  • Type changed from defect to enhancement

Yep, it's a feature. Implemented in trunk with r9892.

comment:7 Changed 3 years ago by robe

  • Keywords history added
Note: See TracTickets for help on using tickets.