Opened 12 years ago
Closed 12 years ago
#1666 closed defect (fixed)
make_dist.sh "pre-2.0.0-tag" does not add postgis_svn_revision.h
| Reported by: | Mike Taves | Owned by: | strk |
|---|---|---|---|
| Priority: | low | Milestone: | PostGIS 2.0.0 |
| Component: | management | Version: | master |
| Keywords: | Cc: |
Description
When running make_dist.sh sometag, an error appears:
Can't open perl script "utils/svn_repo_revision.pl": No such file or directory
.. and so the postgis_svn_revision.h files does not make it into the distribution.
Do we want this file for releases? There is some discussion regarding this file in #1634. If it is desirable, see attached patch.
Attachments (3)
Change History (9)
by , 12 years ago
| Attachment: | make_dist_svn_revision.patch added |
|---|
comment:1 by , 12 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 12 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | assigned → closed |
| Summary: | make_dist.sh does not add postgis_svn_revision.h → make_dist.sh "pre-2.0.0-tag" does not add postgis_svn_revision.h |
After playing with this some I realized what the problem is. The revision fetcher was introduced in 2.0.0, distributing an older release of course won't find it. There's no point, IMHO, in generating the file since nobody will use it anyway.
So I think it's fine to leave the code as it is and not get the file. If your tag is post-2.0.0 feel free to reopen (and change the summary)
comment:3 by , 12 years ago
The important thing is to note that when building with make_dist.sh the "get revision" script is *not* being run inside an SVN checkout, it's being run in an svn export, so it has no local access to svn revision information. It needs to run with the svn tag url to go online and pull the revision number from the tag. As long as you're doing that, everything wlll be OK.
comment:4 by , 12 years ago
| Priority: | medium → low |
|---|---|
| Resolution: | wontfix |
| Status: | closed → reopened |
The new attached patch makes building pre-2.0.0 quieter (no errors) from trunk. Also, there were a few too many owd="$PWD".
by , 12 years ago
| Attachment: | make_dist_pre2quiet.patch added |
|---|
by , 12 years ago
| Attachment: | make_dist_pre2quiet.2.patch added |
|---|
comment:6 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
r9443 makes it quiet when releasing old versions.
Note that pushd/popd are non-posix. http://stackoverflow.com/questions/5193048/bin-sh-pushd-not-found
Also, the unneeded owd/cd lines are meant to keep things in blocks you can move. If you see a bug in there file a ticket for 2.0 milestone, otherwise enhancements can be discussed but better keep changes small and focused for 2.0.
We do want the file for the releases. I thought we were running "make" and "make distclean" from make_dist.sh, so to distribute comments too w/out requiring XSLT.
Now I see we only run "make comments", so could as well run "make postgis_svn_revision.h". I'll try that.