Opened 4 years ago

Closed 3 months ago

#1220 closed task (fixed)

Move logging functions and macros out of liblwgeom.h

Reported by: strk Owned by: strk
Priority: low Milestone: PostGIS 2.2.0
Component: liblwgeom Version: trunk
Keywords: Cc:

Description

All the DEBUG-related macros do not belong to the public header, and they only introduce confusion there. Should be moved somewhere else, liblwgeom_internal.h seems a good bet.

Change History (5)

comment:1 Changed 4 years ago by strk

  • Summary changed from Move LWDEBUG and friends from liblwgeom.h to an internal header to Move logging functions and macros out of liblwgeom.h

Actually also lwerror and lwnotice are likely not useful to have in the public header.

comment:2 Changed 4 years ago by strk

  • Owner changed from postgis-devel@… to strk
  • Status changed from new to assigned

Moving LWDEBUG* macros helped find a couple of files with missing copyright headers and misuse of the LW* macro where the POSTGIS_DEBUG* needed to be used instead.

This first step is in r7907.

lwnotice/lwerror still needs to be moved.

comment:3 Changed 4 years ago by strk

  • Milestone changed from PostGIS 2.0.0 to PostGIS 2.1.0
  • Priority changed from medium to low
  • Type changed from defect to task

comment:4 Changed 2 years ago by robe

  • Milestone changed from PostGIS 2.1.0 to PostGIS Future

comment:5 Changed 3 months ago by strk

  • Milestone changed from PostGIS Future to PostGIS 2.2.0
  • Resolution set to fixed
  • Status changed from assigned to closed

Done with r13652

Note: See TracTickets for help on using tickets.