[raster] check failures under windows 9.1beta3 mingw compiled

[robe]

I'm not sure which is at fault here. The many changes in the restructure of postgis source or the changes in raster.

My 9.0 mingw now make checks fine on everything (postgis, raster (with many warning which I assume I can ignore or have been anyway), topology). My 9.1 beta3 is having issues and seems to crash when it gets to the raster_from_gdal test

all are compiled with gdal trunk r22813. I'll be upgrading my gdal soon to see if that makes a difference:

/lib -lgdal 
./testapi
ERROR 6: Unable to load PROJ.4 library (libproj.dll), creation of
OGRCoordinateTransformation failed.
ERROR 6: Unable to load PROJ.4 library (libproj.dll), creation of
OGRCoordinateTransformation failed.
Checking empty and hasnoband functions...
Checking raster properties...
Raster starts with 0 bands
First point on convexhull ring is 0.5,0.5
Second point on convexhull ring is 256.5,1280.5
Third point on convexhull ring is 1280.5,1536.5
Fourth point on convexhull ring is 1024.5,256.5
Fifth point on convexhull ring is 0.5,0.5
Testing polygonize function
Testing 1BB band
WARNING: Value set for 1BB band got clamped from 2.000000 to 1
WARNING: Value set for 1BB band got clamped from 3.000000 to 1
WARNING: Value set for 1BB band got clamped from 2.000000 to 1
WARNING: Value set for 1BB band got clamped from 3.000000 to 1
Testing 2BB band
WARNING: Value set for 2BUI band got clamped from 4.000000 to 3
WARNING: Value set for 2BUI band got clamped from 5.000000 to 3
WARNING: Value set for 2BUI band got clamped from 4.000000 to 3
WARNING: Value set for 2BUI band got clamped from 5.000000 to 3
Testing 4BUI band
WARNING: Value set for 4BUI band got clamped from 16.000000 to 15
WARNING: Value set for 4BUI band got clamped from 17.000000 to 15
WARNING: Value set for 4BUI band got clamped from 35.000000 to 15
Testing 8BUI band
WARNING: Value set for 8BUI band got clamped from 256.000000 to 255
WARNING: Value set for 8BUI band got clamped from 256.000000 to 255
Testing 8BSI band
WARNING: Value set for 8BSI band got clamped from -129.000000 to -128
WARNING: Value set for 8BSI band got clamped from 129.000000 to 127
WARNING: Value set for 8BSI band got clamped from -129.000000 to -128
WARNING: Value set for 8BSI band got clamped from 129.000000 to 127
Testing 16BSI band
WARNING: Value set for 16BSI band got clamped from -32769.000000 to -32768
WARNING: Value set for 16BSI band got clamped from 32769.000000 to 32767
WARNING: Value set for 16BSI band got clamped from -32769.000000 to -32768
WARNING: Value set for 16BSI band got clamped from 32769.000000 to 32767
ERROR: rt_band_set_pixel: Coordinates out of range
Testing 16BUI band
WARNING: Value set for 16BUI band got clamped from 65536.000000 to 65535
WARNING: Value set for 16BUI band got clamped from 65536.000000 to 65535
ERROR: rt_band_set_pixel: Coordinates out of range
Testing 32BUI band
WARNING: Value set for 32BUI band got clamped from 4294967296.000000 to 42949672        95
WARNING: Value set for 32BUI band got clamped from 4294967296.000000 to 42949672        95
ERROR: rt_band_set_pixel: Coordinates out of range
Testing 32BSI band
WARNING: Value set for 32BSI band got clamped from 2147483648.000000 to 21474836        47
WARNING: Value set for 32BSI band got clamped from 2147483648.000000 to 21474836        47
ERROR: rt_band_set_pixel: Coordinates out of range
Testing 32BF band
Testing 64BF band
Testing band hasnodata flag
Testing rt_raster_from_band
Successfully tested rt_raster_from_band
Testing band stats
Successfully tested band stats
Testing rt_raster_replace_band
Successfully tested rt_raster_replace_band
Testing rt_band_reclass
Successfully tested rt_band_reclass
Testing rt_raster_to_gdal
Successfully tested rt_raster_to_gdal
Testing rt_raster_gdal_drivers
Successfully tested rt_raster_gdal_drivers
Testing rt_band_get_value_count
Successfully tested rt_band_get_value_count
Testing rt_raster_from_gdal_dataset
Successfully tested rt_raster_from_gdal_dataset
Testing rt_raster_gdal_warp
Check failed on line 1540
make[2]: *** [check] Error 1
make[2]: Leaving directory `/c/projects/PostGIS/trunk/raster/test/core'
make[1]: *** [core-check] Error 2
make[1]: Leaving directory `/c/projects/PostGIS/trunk/raster/test'
make: *** [core-check] Error 2

I'm also seeing a lot of gnu_printf messages during make. I'll double-check my 9.0 to see if I see the same. I was ignoring these since they didn't seem to affect compiling.

In file included from c:/projects/pg/pg91b3/include/POSTGR~1/server/c.h:851,
                 from c:/projects/pg/pg91b3/include/POSTGR~1/server/postgres.h:4        7,
                 from rt_pg.c:40:
c:/projects/pg/pg91b3/include/POSTGR~1/server/port.h:200: warning: `gnu_printf'         is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/port.h:204: warning: `gnu_printf'         is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/port.h:209: warning: `gnu_printf'         is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/port.h:213: warning: `gnu_printf'         is an unrecognized format function type
In file included from c:/projects/pg/pg91b3/include/POSTGR~1/server/postgres.h:4        8,
                 from rt_pg.c:40:
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:127: warning: `gnu_printf' is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:133: warning: `gnu_printf' is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:141: warning: `gnu_printf' is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:141: warning: `gnu_pr        intf' is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:147: warning: `gnu_pr        intf' is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:153: warning: `gnu_pr        intf' is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:161: warning: `gnu_pr        intf' is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:161: warning: `gnu_pr        intf' is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:167: warning: `gnu_pr        intf' is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:173: warning: `gnu_pr        intf' is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:200: warning: `gnu_pr        intf' is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:210: warning: `gnu_pr        intf' is an unrecognized format function type
c:/projects/pg/pg91b3/include/POSTGR~1/server/utils/elog.h:369: warning: `gnu_pr        intf' is an unrecognized format function type
In file included from c:/projects/pg/pg91b3/include/POSTGR~1/server/access/xlog.        h:16,
                 from c:/projects/pg/pg91b3/include/POSTGR~1/server/access/gist.        h:19,
                 from rt_pg.c:41:
c:/projects/pg/pg91b3/include/POSTGR~1/server/lib/stringinfo.h:98: warning: `gnu        _printf' is an unrecognized format function type

[robe]

nevermind. I didn't have proj installed on that one. Copying the proj dll to my 9.1 install fixed the tests. However I still get the gnu_printf warning, but it doesn't seem to affect the success of the tests. I don't get the "gnu_printf is an unrecognized format function type" warnings on my 9.0 install.

[dustymugs]

It looks like in 9.1, the devs added something to check the printf type in src/include/pg_config_manual.h. If you take a look at line 157 to 171, the behavior changes for Win32. Is it possible that you may need the lastest mingw to eliminate that warning? Or try modifying those lines in pg_config_manual.h to for force printf rather than gnu_printf?