Opened 13 years ago

Closed 12 years ago

#1153 closed defect (fixed)

uninstall script is broken

Reported by: robe Owned by: strk
Priority: medium Milestone: PostGIS 2.0.0
Component: build Version: master
Keywords: Cc:

Description

The mix of DROP FUNCTION gives error ERROR: function st_minimumboundingcircle(geometry) does not exist

I think this may be because of some of the functions I took out.

All these calls should be really DROP IF EXISTS. We shouldn't have an DROP FUNCTION. But there appers to be a mix of both.

As well as those hideous drop cascades.

Change History (7)

comment:1 by robe, 13 years ago

Priority: highmedium

comment:2 by robe, 12 years ago

Component: postgisbuild/upgrade/install
Owner: changed from pramsey to strk

comment:3 by strk, 12 years ago

Did anyone consider generating the script from postgis.sql ?

comment:4 by strk, 12 years ago

pg_dump —schema-only —clean # seems to be going in the right direction. Mind you: it does do CASCADE!

comment:5 by strk, 12 years ago

As of PostgreSQL 8.4.9, pg_dump is bogus, producing these lines:

DROP TYPE public.spheroid CASCADE;
DROP FUNCTION public.spheroid_out(spheroid);
DROP FUNCTION public.spheroid_in(cstring);

which are clearly in the wrong order

comment:6 by strk, 12 years ago

Beside, the other order would also be broken as you can't drop one w/out dropping the other. Which also means you'll _need_ the CASCADE.

comment:7 by strk, 12 years ago

Resolution: fixed
Status: newclosed

r8505 fixes the script manually. Please file another ticket if there are more issues with it. NOTE: no "IF EXISTS" is added, nor any "CASCADE" was dropped.

Note: See TracTickets for help on using tickets.