Ticket #1135 (closed enhancement: fixed)

Opened 22 months ago

Last modified 17 months ago

Small regression test updates

Reported by: ads Owned by: strk
Priority: medium Milestone: PostGIS 2.0.0
Component: build/upgrade/install Version: 1.5.X
Keywords: Cc: ads@…, andreas.scherbaum@…, ashwin.kumar3@…

Description

As posted earlier on the devel mailinglist:

 http://postgis.refractions.net/pipermail/postgis-devel/2010-October/014441.html (the date is invalid because of server issues)

here are two patches for the regression tests. One patch is for 1.5.3, one for 2.0.0SVN.

From my mail to the mailinglist:


we recently implemented PostGIS in Greenplum (a PostgreSQL fork). The regression tests throwed some errors on us, but mainly only a different output order in the affected .expected files.

Greenplum is a distributed shared-nothing architecture. Unlike PostgreSQL, we will always get the rows in a different order - unless we order them explicitely, like it is required in the SQL standard.

Thinking about it, there is a (although very small) chance, that synchronized sequentiell scans in 8.3 and above will also break these regression tests - as example, if a backup is running at the same time.

Attached you can find a small patch which adds "order by 1" in some of the regression tests, and also changes the output order in some of the .expected files. The data itself is not changed. The patch works with PostgreSQL 9.04 and PostGIS 1.5.3.


Attachments

regress-1.5.3.diff Download (4.2 KB) - added by ads 22 months ago.
regress-2.0.0SVN.diff Download (6.3 KB) - added by ads 22 months ago.

Change History

Changed 22 months ago by ads

Changed 22 months ago by ads

Changed 22 months ago by strk

  • owner changed from pramsey to strk
  • status changed from new to assigned

Changed 22 months ago by strk

  • status changed from assigned to closed
  • resolution set to fixed

Committed to 1.5 branch as r7655 and to trunk as r7656

Thanks a lot!

Changed 22 months ago by strk

Note: I tested both only against PostgreSQL 8.4.8

Changed 22 months ago by robe

  • status changed from closed to reopened
  • resolution fixed deleted

see ticket #1140. This is not working on my windows VC++ 9.0 and 9.1beta3 builds in trunk. I'll try my 8.4 next

Changed 22 months ago by strk

Please try with r7665

Changed 17 months ago by robe

  • component changed from postgis to build/upgrade/install

Changed 17 months ago by strk

robe, as #1140 is closed, will you take care of double checking this one ? Also, it's reported to happen in 1.5, do you want it fixed in 1.5 branch as well ?

Changed 17 months ago by strk

  • status changed from reopened to closed
  • resolution set to fixed

Assuming everyone is happy about this as is.

Note: See TracTickets for help on using tickets.