Opened 8 years ago

Closed 7 years ago

#1135 closed enhancement (fixed)

Small regression test updates

Reported by: ads Owned by: strk
Priority: medium Milestone: PostGIS 2.0.0
Component: build/upgrade/install Version: 1.5.X
Keywords: Cc: ads@…, andreas.scherbaum@…, ashwin.kumar3@…

Description

As posted earlier on the devel mailinglist:

http://postgis.refractions.net/pipermail/postgis-devel/2010-October/014441.html (the date is invalid because of server issues)

here are two patches for the regression tests. One patch is for 1.5.3, one for 2.0.0SVN.

From my mail to the mailinglist:


we recently implemented PostGIS in Greenplum (a PostgreSQL fork). The regression tests throwed some errors on us, but mainly only a different output order in the affected .expected files.

Greenplum is a distributed shared-nothing architecture. Unlike PostgreSQL, we will always get the rows in a different order - unless we order them explicitely, like it is required in the SQL standard.

Thinking about it, there is a (although very small) chance, that synchronized sequentiell scans in 8.3 and above will also break these regression tests - as example, if a backup is running at the same time.

Attached you can find a small patch which adds "order by 1" in some of the regression tests, and also changes the output order in some of the .expected files. The data itself is not changed. The patch works with PostgreSQL 9.04 and PostGIS 1.5.3.


Attachments (2)

regress-1.5.3.diff (4.2 KB) - added by ads 8 years ago.
regress-2.0.0SVN.diff (6.3 KB) - added by ads 8 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by ads

Attachment: regress-1.5.3.diff added

Changed 8 years ago by ads

Attachment: regress-2.0.0SVN.diff added

comment:1 Changed 8 years ago by strk

Owner: changed from pramsey to strk
Status: newassigned

comment:2 Changed 8 years ago by strk

Resolution: fixed
Status: assignedclosed

Committed to 1.5 branch as r7655 and to trunk as r7656

Thanks a lot!

comment:3 Changed 8 years ago by strk

Note: I tested both only against PostgreSQL 8.4.8

comment:4 Changed 8 years ago by robe

Resolution: fixed
Status: closedreopened

see ticket #1140. This is not working on my windows VC++ 9.0 and 9.1beta3 builds in trunk. I'll try my 8.4 next

comment:5 Changed 8 years ago by strk

Please try with r7665

comment:6 Changed 7 years ago by robe

Component: postgisbuild/upgrade/install

comment:7 Changed 7 years ago by strk

robe, as #1140 is closed, will you take care of double checking this one ? Also, it's reported to happen in 1.5, do you want it fixed in 1.5 branch as well ?

comment:8 Changed 7 years ago by strk

Resolution: fixed
Status: reopenedclosed

Assuming everyone is happy about this as is.

Note: See TracTickets for help on using tickets.