Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1083 closed defect (fixed)

Get rid of probe_geometry_columns (typmod support) and other obsolete

Reported by: robe Owned by: robe
Priority: medium Milestone: PostGIS 2.0.0
Component: postgis Version: trunk
Keywords: history Cc:

Description (last modified by robe)

All this function did was to inspect the geometry_columns table and notify of stale entries and add missing entries.

Now that geometry_columns will be a view in 2.0 and we also have typmod, this function and the rest of it's kind are completely irrelevant.

We hadn't marked it for deprecation, but it seems necessary to completely remove it or keep it and have it do nothing except to show a notice that says:

"I do not do anything anymore, get with the program"

I'd just assume drop the function entirely.

There are some dumb ones like rename_geometry_table_constraints() which I didn't even know existed but already does nothing but to tell you it does nothing.

These I have decided to just add to legacy but strip them of their functionality so they just return a "I am obsolete message". Just for those people with old code lying around that happen to call these things.

Functions in this family so far are:

rename_geometry_table_constraints(); fix_geometry_columns(); probe_geometry_columns

Change History (7)

comment:1 Changed 8 years ago by robe

Description: modified (diff)
Summary: Get rid of probe_geometry_columns (typmod support)Get rid of probe_geometry_columns (typmod support) and other obsolete

comment:2 Changed 8 years ago by robe

Resolution: fixed
Status: newclosed

Done at r7548

comment:3 Changed 8 years ago by robe

Keywords: history added

comment:4 Changed 8 years ago by strk

Resolution: fixed
Status: closedreopened

You still have references in the documentation, triggering Hudson complains...

comment:5 Changed 8 years ago by strk

Oh, I think it'd be nice for probe_geometry_columns to still exist and let user know about why it isn't needed anymore.

The idea is an upgrade to postgis-2.0 doesn't force you to rebuild your applications, if possible... (maybe just adding legacy.sql to the install..)

comment:6 Changed 8 years ago by strk

Resolution: fixed
Status: reopenedclosed

Fixed in r7585, let's see if Hudson is happy now.

comment:7 Changed 8 years ago by robe

What? No legacy.sql has to be called explicitly, but I will take it out of of the drop that always gets called if I accidentally put it in there.

I'm having great joy discovering all the junk I have in my 10 year old database that I didn't know I had simply by loading and finding out what kind of crap doesn't load (views that use dumb functions etc). I AM SO HAPPY.

Note: See TracTickets for help on using tickets.