Opened 11 years ago

Closed 5 years ago

#1 closed task (fixed)

Create custom apache port page

Reported by: jmckenna Owned by: jmckenna
Priority: major Component: Installer
Version: Alpha Keywords:
Cc: hhayashi, ksakurai, daisuke, venkat

Description

If Apache is selected a custom page would be presented to select the port number, and indicate if it should be installed as a service.

Attachments (6)

setup-patch.txt (76.1 KB) - added by jmckenna 8 years ago.
setup patch (contains all 3 changes)
opening-dialog.jpg (44.5 KB) - added by jmckenna 8 years ago.
screengrab of opening dialog changes
express-desktop.jpg (21.8 KB) - added by jmckenna 8 years ago.
screengrab of Desktop Install dialog
express-web-gis.jpg (21.7 KB) - added by jmckenna 8 years ago.
screengrab of Web-GIS Install dialog
setup-patch-de.txt (2.6 KB) - added by jef 8 years ago.
update german translation
setup-patch.2.txt (33.9 KB) - added by hhayashi 8 years ago.
fix uDig,OpenEv? checkbox greyed out/inactive

Download all attachments as: .zip

Change History (22)

comment:1 Changed 11 years ago by jmckenna

Version: BetaAlpha

comment:2 Changed 10 years ago by (none)

milestone: Beta Release

Milestone Beta Release deleted

comment:3 Changed 8 years ago by jmckenna

Cc: hhayashi ksakurai daisuke venkat added
Owner: changed from osgeo4w-dev@… to jmckenna
Status: newassigned

Hayashi-san and Sakurai-san from OSGeo-JP have created a patch for setup.exe which contains the following changes:

  • on opening dialog change from "Express install" to 2 separate options: "Express Desktop Install" and "Express Web-GIS Install". Desktop install will only install QGIS, GDAL, GRASS (and disable the web gis options); Web-GIS install will only install MapServer, GDAL, and Apache (and disable the desktop options)
  • the Web-GIS dialog allows user to enter an Apache port number, and that port number is applied to httpd.conf in the post install
  • additional fixes for locale/resource/translations

The patch is submitted as one patch file containing all changes above. I will attach the patch file here. This ticket will be used to test and apply the patch to the setup code.

Changed 8 years ago by jmckenna

Attachment: setup-patch.txt added

setup patch (contains all 3 changes)

Changed 8 years ago by jmckenna

Attachment: opening-dialog.jpg added

screengrab of opening dialog changes

Changed 8 years ago by jmckenna

Attachment: express-desktop.jpg added

screengrab of Desktop Install dialog

Changed 8 years ago by jmckenna

Attachment: express-web-gis.jpg added

screengrab of Web-GIS Install dialog

comment:4 Changed 8 years ago by jmckenna

I have attached screengrabs of the patch in action.

comment:5 Changed 8 years ago by jmckenna

For the record, to test the new setup.exe, the following changes need to be made to the Apache package:

"Apache port change logic need to modify apache configuration file "httpd.conf".

1)Change Port Number to Keyword.
In "http://download.osgeo.org/osgeo4w/release/apache/",

Need to edit the httpd.conf file.
At Line 46, Modify "Listen 80" to "Listen @apache_port_number@"

2)Add textreplace line command to Apache.bat

In /etc/postinstall/apache.bat
Add command line as below.
textreplace -sf apache/conf/httpd.conf -df apache/conf/httpd.conf -map @apache_port_number@  %APACHE_PORT%

An Apache package with this change is available: http://download.osgeo.org/osgeo4w/release/apache/apache-2.2.14-4.tar.bz2

comment:6 Changed 8 years ago by jmckenna

Hayashi-san and Sakurai-san,

I have tested the Apache port changes on Windows7 successfully.

One problem: for the "Express Web-GIS Install", the "uDig" and "OpenEV" items should be greyed out/inactive, similar to "Quantum GIS" and "GRASS". Can you make that change and create a new 'setup-patch.txt' file, that contains all of the changes compared to current SVN, and attach it to this ticket?

Once those changes are made I will re-test, and then apply the changes to SVN.

-jeff

Changed 8 years ago by jef

Attachment: setup-patch-de.txt added

update german translation

comment:7 in reply to:  3 ; Changed 8 years ago by jef

Replying to jmckenna:

  • on opening dialog change from "Express install" to 2 separate options: "Express Desktop Install" and "Express Web-GIS Install". Desktop install will only install QGIS, GDAL, GRASS (and disable the web gis options); Web-GIS install will only install MapServer, GDAL, and Apache (and disable the desktop options)

I don't see an advantage here. The user can just leave the express targets he doesn't want alone. Why disable some (but still show them grayed out)? And some might even want both desktop and webgis (eg. to use QGIS to export mapfiles and mapserver to test them).

And installing QGIS, GRASS or MapServer should already trigger GDAL. The GDAL express target is for installing the command line tools - so it's neither Desktop nor WebGIS.

comment:8 in reply to:  5 Changed 8 years ago by jef

Replying to jmckenna:

textreplace -sf apache/conf/httpd.conf -df apache/conf/httpd.conf -map @apache_port_number@ %APACHE_PORT%

Does the patch consider that apache might be installed via "Advanced install", ie. w/o an explicitely set port?

Changed 8 years ago by hhayashi

Attachment: setup-patch.2.txt added

fix uDig,OpenEv? checkbox greyed out/inactive

comment:9 in reply to:  6 Changed 8 years ago by hhayashi

Hi Jeff, Thank you for your testing. I modified "uDig and OpenEv? greyed out/inactive".

Replying to jmckenna:

Hayashi-san and Sakurai-san,

I have tested the Apache port changes on Windows7 successfully.

One problem: for the "Express Web-GIS Install", the "uDig" and "OpenEV" items should be greyed out/inactive, similar to "Quantum GIS" and "GRASS". Can you make that change and create a new 'setup-patch.txt' file, that contains all of the changes compared to current SVN, and attach it to this ticket?

Once those changes are made I will re-test, and then apply the changes to SVN.

-jeff

comment:10 in reply to:  7 ; Changed 8 years ago by jmckenna

Replying to jef:

I don't see an advantage here. The user can just leave the express targets he doesn't want alone. Why disable some (but still show them grayed out)? And some might even want both desktop and webgis (eg. to use QGIS to export mapfiles and mapserver to test them).

The OSGeo-Japan community has held many workshops using OSGeo4W and this change was a result of feedback from the users. I do see your point that there is not much advantage, but it does help new users who might not know the different OSGeo projects.

And installing QGIS, GRASS or MapServer should already trigger GDAL. The GDAL express target is for installing the command line tools - so it's neither Desktop nor WebGIS.

This patch does list the GDAL commandline tools in both Express versions. I see no problem with that (the user can unclick to remove if they wish).

comment:11 Changed 8 years ago by jmckenna

  • setup-patch.txt has been applied and checked into SVN
  • osgeo4w-setup.exe and setup package has been uploaded to download server
  • apache package has been modified for the port change requirements and is live
  • also updated apache postinstall startmenu shortcuts

jef: can you re-attach your setup-patch-de.txt file to this ticket, against the latest SVN? thanks.

comment:12 Changed 8 years ago by jmckenna

also:

  • tested Apache package using Advanced mode successfully
    • Apache defaults to port 80
      • from patch:
           int apache_port_number=80;
        

comment:13 in reply to:  10 Changed 8 years ago by jef

Replying to jmckenna:

I do see your point that there is not much advantage, but it does help new users who might not know the different OSGeo projects.

The the express targets should better be shown grouped by Desktop and webGIS (and command line). I still don't see what good a xor does.

This patch does list the GDAL commandline tools in both Express versions. I see no problem with that (the user can unclick to remove if they wish).

I was just saying that GDAL doesn't belong in either category. So deciding between Desktop or webGIS doesn't make sense for GDAL.

comment:14 in reply to:  11 Changed 8 years ago by jef

Replying to jmckenna:

can you re-attach your setup-patch-de.txt file to this ticket, against the latest SVN? thanks.

already committed.

comment:15 Changed 8 years ago by jmckenna

great, I have repacked it with your -de changes and uploaded to server.

comment:16 Changed 5 years ago by jef

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.