Opened 20 years ago

Closed 20 years ago

#891 closed defect (fixed)

[WCS] All XML output should be encoded

Reported by: jlacroix Owned by: sdlime
Priority: high Milestone:
Component: WCS Server Version: 4.3
Severity: normal Keywords:
Cc:

Description

In Bug 802, all metadatas and mapfile parameters have been HTML encoded to
prevent MapServer from outputing invalid XML file.

The same should be done for WCS.

This can be done easily by changing all msOWSPrintMetadata and msOWSPrintParam
to msOWSPrintEncodeMetadata and msPrintEncodeParam.

Check Bug 802 for more details.

Change History (6)

comment:1 by jlacroix, 20 years ago

Cc: mapserver-bugs@… added

comment:2 by jlacroix, 20 years ago

Steve,
Is there anything to do in the WCS code for this? 

All value that we output to a XML document should be HTML encoded. I did not
touch it since I don't know what is the status of the code.

If nothing have to be done, please mark the bug as INVALID. And if you want me
to work on it, please reassign it to mapserver-bug at dmsolutions.ca

comment:3 by sdlime, 20 years ago

Just need to switch the calls as described in the original description. I can 
handle or you can too if you have the time. Are the msOWSPrintMetadata and 
msOWSPrintParam function still used at all then?

Steve

comment:4 by jlacroix, 20 years ago

You can maybe do a grep, but I think that those two functions are only in
mapwcs.c now. I replaced all other occurence. I will leave it too you this bug
for now, if you don't have time let me know, but for this week I may be overbooked.

comment:5 by dmorissette, 20 years ago

I think there may still be uses for the msOWSPrintMetadata() and
msOWSPrintParam() functions, so I would not take them out yet.

comment:6 by sdlime, 20 years ago

Resolution: fixed
Status: newclosed
Fixed, just committed the changes for WCS.

Steve
Note: See TracTickets for help on using tickets.